Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional debugging logging #152

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

jwhonce
Copy link
Contributor

@jwhonce jwhonce commented Feb 1, 2018

  • Turn on more debugging logging
  • Change container logging to json-file driver

Signed-off-by: Jhon Honce [email protected]

* Change container logging to json-file driver

Signed-off-by: Jhon Honce <[email protected]>
@jwhonce jwhonce self-assigned this Feb 1, 2018
@jwhonce
Copy link
Contributor Author

jwhonce commented Feb 1, 2018

@rhvgoyal FYI

@stevekuznetsov
Copy link
Contributor

So I think this will be safe since jsonfile will make sure that we don't get rate-limited from the debug output like last time when we were using journald. @sdodson does this impact how the installer works at all and also @jcantrill FYI if you have journald tests you may need to reconfigure them if the default changes under you

@jwhonce
Copy link
Contributor Author

jwhonce commented Feb 1, 2018

@sjenning FYI

@sdodson
Copy link
Member

sdodson commented Feb 1, 2018

@stevekuznetsov I don't think it will cause any problems, but we also don't set log driver in the latest code.

@rhvgoyal
Copy link

rhvgoyal commented Feb 2, 2018

Thanks @jwhonce

@stevekuznetsov
Copy link
Contributor

@jcantrill @richm y'all have any concerns with this?

@richm
Copy link
Contributor

richm commented Feb 2, 2018

I just don't know what impact this will have on the logging CI.

I'm assuming we will still be able to turn on docker log-driver=journald as we do now: https://github.com/openshift/aos-cd-jobs/blob/master/sjb/config/test_cases/test_pull_request_origin_aggregated_logging_ansible.yml#L123

I'm also assuming the extra debug information from the docker daemon debugging doesn't cause problems with our logging tests.

@stevekuznetsov
Copy link
Contributor

@richm OK, if you are aware of the change and are willing to monitor your jobs for a bit I will pull this in. Any objections?

@richm
Copy link
Contributor

richm commented Feb 2, 2018

ok - sounds good - I warned the team to be on the lookout for test flakes due to this.

@stevekuznetsov stevekuznetsov merged commit 7cad7b0 into openshift:master Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants