Skip to content

Commit

Permalink
Fix bug deleting bindings for service instance
Browse files Browse the repository at this point in the history
The logic checking if the binding was already deleted was flipped.
  • Loading branch information
spadgett committed Oct 6, 2017
1 parent ec0a953 commit 4aa9a1c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/scripts/services/serviceInstances.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ angular.module("openshiftConsole")
var resource = APIService.getPreferredVersion('serviceinstancecredentials');
getBindingsIfNecessary(apiObject, bindings).then(function(serviceBindings) {
_.each(serviceBindings, function (binding) {
if (!binding.metadata.deletionTimestamp) {
if (binding.metadata.deletionTimestamp) {
return;
}

Expand Down
2 changes: 1 addition & 1 deletion dist/scripts/scripts.js
Original file line number Diff line number Diff line change
Expand Up @@ -4315,7 +4315,7 @@ namespace: t.metadata.namespace
}, u = a.getPreferredVersion("serviceinstancecredentials");
l(t, n).then(function(t) {
_.each(t, function(t) {
t.metadata.deletionTimestamp && i.delete(u, t.metadata.name, r).then(function() {
t.metadata.deletionTimestamp || i.delete(u, t.metadata.name, r).then(function() {
c.addNotification({
type: "success",
message: "Binding " + t.metadata.name + "' was marked for deletion."
Expand Down

0 comments on commit 4aa9a1c

Please sign in to comment.