Correctly merge env edits after background upates

openshift · Oct 31, 2017 · 4fa90c7 · 4fa90c7
1 parent 9b48a7b
commit 4fa90c7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/scripts/directives/editEnvironmentVariables.js b/app/scripts/directives/editEnvironmentVariables.js
@@ -52,7 +52,7 @@
       // variables. If not, merge the environment edits into the updated
       // deployment config object.
       if (EnvironmentService.isEnvironmentEqual(currentValue, previousValue)) {
-        ctrl.updatedObject = EnvironmentService.mergeEdits(currentValue, previousValue);
+        ctrl.updatedObject = EnvironmentService.mergeEdits(ctrl.updatedObject, currentValue);
         return;
       }
 

diff --git a/dist/scripts/scripts.js b/dist/scripts/scripts.js
@@ -14467,7 +14467,7 @@ bottom: n.offsetBottom
 angular.module("openshiftConsole").component("editEnvironmentVariables", {
 controller: [ "$filter", "APIService", "DataService", "EnvironmentService", "NotificationsService", function(e, t, n, a, r) {
 var o, i, s, c, l = this, u = !1, d = [], m = [], p = !1, f = e("canI"), g = e("getErrorDetails"), v = e("humanizeKind"), h = e("orderByDisplayName"), y = function(e, t) {
-u || (l.form && !l.form.$pristine && l.updatedObject ? a.isEnvironmentEqual(e, t) ? l.updatedObject = a.mergeEdits(e, t) : (u = !0, r.addNotification({
+u || (l.form && !l.form.$pristine && l.updatedObject ? a.isEnvironmentEqual(e, t) ? l.updatedObject = a.mergeEdits(l.updatedObject, e) : (u = !0, r.addNotification({
 type: "warning",
 message: "The environment variables for the " + o + " have been updated in the background.",
 details: "Saving your changes may create a conflict or cause loss of data."