Skip to content

Commit

Permalink
Merge pull request #2389 from rhamilto/h1-tweak
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue.

Adjust h1 margins so page header border aligns with left nav item

The misalignment of the page-header bottom border and the left nav divider bugs me.

![screen shot 2017-10-27 at 9 44 00 am](https://user-images.githubusercontent.com/895728/32107231-fcade1d8-bafb-11e7-8873-68f3797d65be.PNG)

It's better to have them align?

![screen shot 2017-10-27 at 9 43 48 am](https://user-images.githubusercontent.com/895728/32107267-17c4a556-bafc-11e7-8986-9f5f19f19d93.PNG)
  • Loading branch information
openshift-merge-robot authored Oct 27, 2017
2 parents d5e50e6 + d3c8740 commit bcff08c
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 14 deletions.
17 changes: 6 additions & 11 deletions app/styles/_typography.less
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,14 @@
margin-bottom: 0;
margin-left: -20px;
margin-right: -20px;
margin-top: 20px;
padding-left: 20px;
padding-right: 20px;
margin-top: 0;
padding: 18px 20px 19px;
.actions {
margin-top: 0;
}
h1 {
margin: 0;
}
}
.page-header-link {
display: inline-block;
Expand All @@ -20,14 +22,6 @@
margin: 0 10px;
white-space: nowrap;
}
// @media (min-width: @screen-md-min) {
// .page-header.page-header-bleed-left {
// margin-left: -30px;
// padding-left: 30px;
// margin-right: -30px;
// padding-right: 30px;
// }
// }
.section-header{
.page-header();
border-bottom: none;
Expand All @@ -36,6 +30,7 @@
}

h1 {
margin-top: 18px;
&.contains-actions {
.word-break();
}
Expand Down
8 changes: 5 additions & 3 deletions dist/styles/main.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit bcff08c

Please sign in to comment.