-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pod initializing has no status icon #2295
Comments
@jwforres Is this similar to anything we already have? Not sure if in progress or building/ running icons would fit. |
I was thinking the pending icon, but I'm OK with running, too. |
so it looks like the pod is in Pending when the init containers are running |
Good point, the pending icon might make a lot of sense @spadgett! I forget if that is a new one @jennyhaines created or if OpenShift already has that icon elsewhere? |
@beanh66 @spadgett @jwforres Yes, I think the pending icon would work nicely. That was an icon I added recently. Sidenote: I would not recommend using the "in progress" PF icon... in the latest icon user testing, it had unfavorable results, and I'll likely need to change it. |
@beanh66 @jennyhaines wdyt? |
I really like it! @jwforres |
Your eyes must be better than mine, I can't tell what that is, lol. |
@jennyhaines @jeff-phillips-18 since we aren't using the matching patternfly icons in this context yet - until we do the font-awesome hourglass icon matches better since it doesn't have the surrounding circle Its also more clear at this font size that it is an hourglass. I worry long term about the patternfly icons not being clear enough unless we increase the font size :( |
@jwforres - That is a good point. I'll make a note to take another look at our pending icon being freed of it's circle so it can be a little more clear at 14px! I will have to make some changes later on to another status icon, anyway, based on user testing. I think this font-awesome solution works for now. |
@jwforres Agreed, hour glass without the circle looks good here |
Automatic merge from submit-queue. Update pending states to use hourglass - adds icon for Pod Initializing Fixes #2295
the PodInitializing state has no icon, now that builds use init containers this state is going to be very common in the console
@openshift/team-ux-review
The text was updated successfully, but these errors were encountered: