Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod initializing has no status icon #2295

Closed
jwforres opened this issue Oct 17, 2017 · 13 comments
Closed

Pod initializing has no status icon #2295

jwforres opened this issue Oct 17, 2017 · 13 comments
Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P3

Comments

@jwforres
Copy link
Member

the PodInitializing state has no icon, now that builds use init containers this state is going to be very common in the console

screen shot 2017-10-17 at 5 13 46 pm

@openshift/team-ux-review

@jwforres jwforres added area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P3 labels Oct 17, 2017
@beanh66
Copy link

beanh66 commented Oct 18, 2017

@jwforres Is this similar to anything we already have? Not sure if in progress or building/ running icons would fit.

@jwforres
Copy link
Member Author

@beanh66 the running icon wouldn't be completely inaccurate, it is running containers at that point, its just not running the "main" container(s) yet

@spadgett thoughts?

@spadgett
Copy link
Member

I was thinking the pending icon, but I'm OK with running, too.

@jwforres
Copy link
Member Author

so it looks like the pod is in Pending when the init containers are running

@beanh66
Copy link

beanh66 commented Oct 18, 2017

Good point, the pending icon might make a lot of sense @spadgett! I forget if that is a new one @jennyhaines created or if OpenShift already has that icon elsewhere?

@jennyhaines
Copy link

jennyhaines commented Oct 18, 2017

@beanh66 @spadgett @jwforres Yes, I think the pending icon would work nicely. That was an icon I added recently.
pending
I do not remember seeing it used anywhere in OpenShift thus far.

Sidenote: I would not recommend using the "in progress" PF icon... in the latest icon user testing, it had unfavorable results, and I'll likely need to change it.

@jwforres
Copy link
Member Author

@beanh66 @jennyhaines wdyt?

podinit

@jennyhaines
Copy link

I really like it! @jwforres

@jeff-phillips-18
Copy link
Member

Your eyes must be better than mine, I can't tell what that is, lol.

@jwforres
Copy link
Member Author

I agree its a little hard to tell that its an hourglass icon at that font size :-\

so the one we use today for the "Pending" state in openshift is different, whichever one we use it should probably be the same one in both cases

This is what that one looks like:

2017-10-18 15 30 26

@jwforres
Copy link
Member Author

@jennyhaines @jeff-phillips-18 since we aren't using the matching patternfly icons in this context yet - until we do the font-awesome hourglass icon matches better since it doesn't have the surrounding circle

initializing

Its also more clear at this font size that it is an hourglass. I worry long term about the patternfly icons not being clear enough unless we increase the font size :(

@jennyhaines
Copy link

@jwforres - That is a good point. I'll make a note to take another look at our pending icon being freed of it's circle so it can be a little more clear at 14px! I will have to make some changes later on to another status icon, anyway, based on user testing. I think this font-awesome solution works for now.

@beanh66
Copy link

beanh66 commented Oct 19, 2017

@jwforres Agreed, hour glass without the circle looks good here

openshift-merge-robot added a commit that referenced this issue Oct 19, 2017
Automatic merge from submit-queue.

Update pending states to use hourglass - adds icon for Pod Initializing

Fixes #2295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P3
Projects
None yet
Development

No branches or pull requests

5 participants