Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling background updates in the environment editor is broken #2394

Closed
spadgett opened this issue Oct 30, 2017 · 0 comments
Closed

Handling background updates in the environment editor is broken #2394

spadgett opened this issue Oct 30, 2017 · 0 comments
Assignees
@spadgett
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2
Milestone
3.7.0

Comments

@spadgett
Copy link
Member

We used to be able to merge background updates with environment variable changes. This no longer works and always results in a conflict, even when no environment variables have changed in the background update.
@spadgett spadgett added kind/bug Categorizes issue or PR as related to a bug. priority/P2 labels Oct 30, 2017
@spadgett spadgett added this to the 3.7.0 milestone Oct 30, 2017
@spadgett spadgett self-assigned this Oct 30, 2017
@spadgett spadgett mentioned this issue Oct 31, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Nov 1, 2017
@openshift-merge-robot
Merge pull request #2407 from spadgett/edit-env-background-update
57ae92d 
Automatic merge from submit-queue.

Correctly merge env edits after background upates

Fixes #2394

/kind bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spadgett spadgett

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
1 participant
@spadgett