Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime error in env variable editor #2460

Closed
spadgett opened this issue Nov 6, 2017 · 0 comments
Closed

Runtime error in env variable editor #2460

spadgett opened this issue Nov 6, 2017 · 0 comments
Assignees
@spadgett
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P1
Milestone
3.7.0

Comments

@spadgett
Copy link
Member

spadgett commented Nov 6, 2017 •
edited
Loading

This error occurs in the deployment config editor on load.

screen shot 2017-11-06 at 8 14 06 am

Error: option is undefined
findSecret/<.object<@https://localhost:9000/dev-console/scripts/services/keyValueEditorUtils.js:200:15
baseFindIndex@https://localhost:9000/dev-console/bower_components/lodash/lodash.js:823:11
findIndex@https://localhost:9000/dev-console/bower_components/lodash/lodash.js:7275:14
createFind/<@https://localhost:9000/dev-console/bower_components/lodash/lodash.js:5098:21
findSecret@https://localhost:9000/dev-console/scripts/services/keyValueEditorUtils.js:199:21
findReferenceValue@https://localhost:9000/dev-console/scripts/services/keyValueEditorUtils.js:212:19
findReferenceValueForEntries/<@https://localhost:9000/dev-console/scripts/services/keyValueEditorUtils.js:221:32
arrayEach@https://localhost:9000/dev-console/bower_components/lodash/lodash.js:537:11
forEach@https://localhost:9000/dev-console/bower_components/lodash/lodash.js:9359:14
findReferenceValueForEntries@https://localhost:9000/dev-console/scripts/services/keyValueEditorUtils.js:218:11
.controller</<@https://localhost:9000/dev-console/scripts/directives/keyValueEditor.js:304:17
$digest@https://localhost:9000/dev-console/bower_components/angular/angular.js:17836:23
$apply@https://localhost:9000/dev-console/bower_components/angular/angular.js:18102:13
done@https://localhost:9000/dev-console/bower_components/angular/angular.js:12082:36
completeRequest@https://localhost:9000/dev-console/bower_components/angular/angular.js:12291:7
requestLoaded@https://localhost:9000/dev-console/bower_components/angular/angular.js:12219:9

cc @jwforres
@spadgett spadgett added kind/bug Categorizes issue or PR as related to a bug. priority/P1 labels Nov 6, 2017
@spadgett spadgett added this to the 3.7.0 milestone Nov 6, 2017
@spadgett spadgett self-assigned this Nov 6, 2017
@spadgett spadgett mentioned this issue Nov 6, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Nov 6, 2017
@openshift-merge-robot
Merge pull request #2461 from spadgett/value-from-hook
228caa6 
Automatic merge from submit-queue.

Fix problems with env valueFrom for DC hooks

![screen shot 2017-11-06 at 8 26 19 am](https://user-images.githubusercontent.com/1167259/32443765-258629d8-c2ce-11e7-91db-47d2e9f91f78.png)

* Avoid adding an `undefined` element to value from array depending on the
  order that config maps and secrets load
* Fix typo passing config maps to edit-lifecycle-hooks
* Show valueFrom values for hooks when viewing the deployment config

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1509842
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1509819
Fixes #2460

/kind bug
/assign @jwforres
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spadgett spadgett

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P1
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
1 participant
@spadgett