Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Membership Add Role cannot see dropdown contents #2614

Closed
karlnicholas opened this issue Dec 31, 2017 · 15 comments · Fixed by #2860
Closed

Membership Add Role cannot see dropdown contents #2614

karlnicholas opened this issue Dec 31, 2017 · 15 comments · Fixed by #2860
Assignees
Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P2

Comments

@karlnicholas
Copy link

When attempting to add a another role in openshift online membership screen you cannot see the description of the roles.

image

@spadgett
Copy link
Member

spadgett commented Jan 2, 2018

Should be fixed by #2402 since these system roles will be hidden.

@spadgett spadgett added area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P2 labels Jan 2, 2018
@spadgett
Copy link
Member

spadgett commented Jan 2, 2018

@karlnicholas Can I ask which Online cluster you saw this on?

@karlnicholas
Copy link
Author

karlnicholas commented Jan 2, 2018

I was on pro-us-east-1 with "show hidden roles" enabled.

@spadgett
Copy link
Member

spadgett commented Jan 2, 2018

Ah OK, thanks. These roles might not have descriptions since they're system roles, although it's clearly a problem that you can't see the full name and they all have the same prefix.

/cc @rhamilto @sg00dwin

@benjaminapetersen
Copy link
Contributor

Descriptions do wrap:
screen shot 2018-01-02 at 2 11 06 pm

And tablet/mobile view has a better view of the long names, though still not perfect:
screen shot 2018-01-02 at 2 12 11 pm

@spadgett
Copy link
Member

spadgett commented Jan 2, 2018

If we could find a way to make the dropdown wider at desktop, I think it would help generally. The description wrap, but they are long enough that you only see a few items at a time. And of course in this case the names are cut off at desktop.

@benjaminapetersen
Copy link
Contributor

Yeah I'm tinkering with that a little bit. Not sure if we should make it wider, or wrap them (kinda ugly). I'm guessing the max char length possible is quite high...

@spadgett
Copy link
Member

spadgett commented Jan 2, 2018

We could also add a title attribute to the elements so at least you can hover and see.

Related to #1219

@spadgett
Copy link
Member

spadgett commented Jan 2, 2018

@openshift/team-ux-review

@benjaminapetersen
Copy link
Contributor

I'm inclined that way as well. Is a bit annoying, but there would certainly be a way to see the entire name no matter the length then.

@spadgett
Copy link
Member

spadgett commented Jan 2, 2018

It'd be a stop gap fix until we can do something better. It's not a great user experience if you need to hover over every item, but at least you can see.

@ncameronbritt
Copy link

Something similar to what @beanh66 proposed for adding labels could be a possibility. Rather than having the selector as part of the table, an "add role" action could bring up a modal. That might more easily accommodate longer names and make the descriptions easier to read.

openshift-merge-robot added a commit that referenced this issue Jan 3, 2018
…-role-title

Automatic merge from submit-queue.

Add titles to roles in dropdown list on membership page

Partial Fix for 2614, at least as a short term until we decide on a better solution.  See the conversation for more details.

Adds titles to the menu items:

![screen shot 2018-01-03 at 11 18 25 am](https://user-images.githubusercontent.com/280512/34528830-1d9208b4-f078-11e7-96b3-1585bce2b90d.png)

Re: #2614
@rhamilto
Copy link
Member

Any objections to eliminating the three column layout at desktop resolutions to resolve the bug as an interim solution?

Note: this is a rough mock
screen shot 2018-02-27 at 10 28 50 am

@sg00dwin
Copy link
Member

+1 works for me

@benjaminapetersen
Copy link
Contributor

not a prob imo.

openshift-merge-robot added a commit that referenced this issue Mar 1, 2018
Automatic merge from submit-queue.

Removing layout.attrs to reduce dependencies

Also fixes #2614 by eliminating the three column layout for desktop resolutions
![screen shot 2018-02-28 at 10 24 44 am](https://user-images.githubusercontent.com/895728/36795665-a1f95ba0-1c71-11e8-97b6-7f81c3e20583.PNG)

And updates volume-claim-template heading to the new style
Before:
![screen shot 2018-02-28 at 9 45 29 am](https://user-images.githubusercontent.com/895728/36795769-dd18272a-1c71-11e8-9181-17b9a672e4bf.PNG)
After:
![screen shot 2018-02-28 at 9 45 35 am](https://user-images.githubusercontent.com/895728/36795785-e549e7da-1c71-11e8-9304-0c0b18eb256f.PNG)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants