Let users save logs #1040
Let users save logs #1040
Conversation
|
I really hesitate to call this Save if it's only copying the part of the log that we have loaded |
|
We could warn if it's only part of the log (and give the CLI command) |
|
Nice to get this feature back with such a small lib! |
|
Something like this:
|
|
Sure but the command should be the full width copy to clipboard
…On Dec 14, 2016 4:35 PM, "Sam Padgett" ***@***.***> wrote:
Something like this:
[image: screen shot 2016-12-14 at 4 30 03 pm]
<https://cloud.githubusercontent.com/assets/1167259/21202027/326d1c2e-c21b-11e6-9756-7bcfd0731dbb.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1040 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZk7a1_qFU6vkHqz2METjmG0hExgGIUks5rIGEUgaJpZM4LNVTR>
.
|
Yeah, needs a custom dialog to use the directive. Working on it. |
|
@jwforres Updated. Note I added some tests for Here is the current dialog:
|
|
does the command line tools link open in a new tab? i would prefer that
over it dismissing the dialog
…On Thu, Dec 15, 2016 at 9:08 AM, Sam Padgett ***@***.***> wrote:
@jwforres <https://github.com/jwforres> Updated. Note I added some tests
for CLIHelp (bottom of diff).
Here is the current dialog:
[image: screen shot 2016-12-15 at 8 59 06 am]
<https://cloud.githubusercontent.com/assets/1167259/21226953/dafa6074-c2a5-11e6-8138-0063af88fb50.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1040 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZk7bwTbJZOtV89hjUAOmIdYuOS9wuOks5rIUnrgaJpZM4LNVTR>
.
|
Yes |
|
What happens if we have 5000 really long log lines and we hit the 500MiB limit in some of the browsers? Or does the log viewer already fall over at that point :) |
|
Can you add a comment above that line that if we ever increase that limit that we can't go over the Blob limit |
|
otherwise this LGTM |
|
Thanks @jwforres, added the comment about [merge] |
Adds a "Save" link to the log viewer that saves the log contents as a file.
|
Fixed typo in test string [merge] |
|
[merge] |
|
Evaluated for origin web console merge up to 6ba8911 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/861/) (Base Commit: 8e40552) |
Adds a "Save" link to the log viewer that saves the log contents as a file. Closes #356
https://trello.com/c/OaF7o3U3
Saves just the log text for logs that have links or colors. Does not add in the line numbers.
Uses library https://github.com/eligrey/FileSaver.js which is very small (< 200 lines of code). See browser support here:
https://github.com/eligrey/FileSaver.js#supported-browsers
Tested with Chrome, Firefox, Safari, IE, and iOS. On iOS, it opens a new window with the plain log text:
cc @benjaminapetersen