Show a slider to select service weights #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
changed the title
spadgett
force-pushed
the
weight-slider
branch
3 times, most recently
from
2c3152c to
f5d9baa
Compare
jwforres
reviewed
Dec 19, 2016
| ng-model="controls.rangeSlider" | ||
| aria-describedby="weight-slider-help" | ||
| class="mar-top-md"> | ||
| <!-- Use class="hidden" to make sure the options don't render for browsers that don't support datalist. --> |
There was a problem hiding this comment.
how does it look on the ones that do support, it looked like it was just Safari and iOS that didnt
There was a problem hiding this comment.
I can probably take it out. It doesn't show up in Safari and iOS.
When editing a route with two services, let users change the service weights using a slider. For 3 or more services, fall back to entering the weight values as integers.
spadgett
force-pushed
the
weight-slider
branch
from
f5d9baa to
f89c374
Compare
|
Removed |
jwforres
approved these changes
Dec 19, 2016
|
LGTM, you can merge if you are done making changes |
|
[merge] |
|
Evaluated for origin web console merge up to f89c374 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/873/) (Base Commit: 6010439) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing a route with two services, let users change the service weights as percentages using a slider. For 3 or more services, fall back to entering the weight values as integers.
Fixes #241