Improve Jenkinsfile examples #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwforres This makes the dialog larger, but it scrolls OK on smaller screens. |
|
I'd be tempted to combine the first and last ones, and just make the build/deploy the first example. That would shorten it up a bit, four large example blocks feels a little overwhelming |
|
@jwforres better?
|
Show more complete examples, including running commands on labelled nodes.
spadgett
force-pushed
the
pipeline-node-example
branch
from
4949035 to
baeb6cb
Compare
|
yeah that seems better to me
…On Tue, Jan 3, 2017 at 1:00 PM, Sam Padgett ***@***.***> wrote:
@jwforres <https://github.com/jwforres> better?
[image: screen shot 2017-01-03 at 12 59 05 pm]
<https://cloud.githubusercontent.com/assets/1167259/21617511/792fd9a0-d1b4-11e6-9c83-d08701b64040.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1074 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZk7WM3BC0W-27k6bs59Fi12KVvnDWvks5rOoyugaJpZM4LZ2ii>
.
|
|
The examples look good to me |
jwforres
approved these changes
Jan 3, 2017
|
[merge] |
|
Evaluated for origin web console merge up to baeb6cb |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/894/) (Base Commit: 0b1435e) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show more complete examples, including running commands on labelled nodes.
@csrwng Do these examples look correct / realisitc?
Fixes #952