Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use metadata.name as secondary sort for projects #1081

Merged
merged 1 commit into from
Jan 5, 2017

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Jan 5, 2017

Update the projects page and orderByDisplayName filter to use
metadata.name as a secondary sort when projects have the same display
name.

Fixes #915

Update the projects page and `orderByDisplayName` filter to use
`metadata.name` as a secondary sort when projects have the same display
name.
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, works well when tested with 5 projects with 'Sorted project' as display name, but names of aaa,bbb,ccc,ddd,eee. Master does not sort consistently, this update does.

@spadgett
Copy link
Member Author

spadgett commented Jan 5, 2017

@benjaminapetersen thanks

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 42a1b98

@openshift-bot
Copy link

openshift-bot commented Jan 5, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/902/) (Base Commit: 3656be7)

@openshift-bot openshift-bot merged commit 81127a4 into openshift:master Jan 5, 2017
@spadgett spadgett deleted the stable-project-sort branch January 5, 2017 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants