Truncate long event messages to 1000 characters #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwforres
approved these changes
Jan 5, 2017
jwforres
reviewed
Jan 5, 2017
spadgett
force-pushed
the
truncate-event-msg
branch
2 times, most recently
from
5eaad09 to
69479a0
Compare
|
@jwforres I added optional keyword highlighting to the |
jwforres
approved these changes
Jan 5, 2017
|
[merge] |
|
Hold, I found a minor issue with JSON formatting :/ |
Occasionally an event can have a long message. Limit the length to 1000 characters or 4 lines in the events table.
spadgett
force-pushed
the
truncate-event-msg
branch
from
69479a0 to
87ca1f4
Compare
|
@jwforres Moved the [merge] |
|
Evaluated for origin web console merge up to 87ca1f4 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/901/) (Base Commit: f0e8144) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally an event can have a long message. Limit the length to 1000 characters or 4 lines in the events table.
Fixes #54