Bug 1411258, Bug 1411266 - Fix editing existing commands #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first edit made when editing an existing command is ignored. The `argsChanged` value is not properly reset on the first `input.args` watch callback, so changes are not saved unless there is a second edit. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1411258 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1411266
spadgett
force-pushed
the
fix-command-editor
branch
from
c63dda7 to
703aa68
Compare
spadgett
changed the title
jwforres
approved these changes
Jan 9, 2017
|
[merge] |
|
Evaluated for origin web console merge up to 703aa68 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/905/) (Base Commit: 1bea253) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first edit made when editing an existing command is ignored. The
argsChangedvalue is not properly reset on the firstinput.argswatchcallback, so changes are not saved unless there is a second edit.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1411258
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1411266