Collapse pending pipelines on overview #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't show the expanded view (with stages) for pipelines that haven't started. Since we now have run policy for build configs, it's possible to queue up several pipeline builds. They take up a lot of space on the overview when expanded and don't have any stage details until they actually start running.
spadgett
commented
Jan 17, 2017
| @@ -418,10 +417,6 @@ angular.module('openshiftConsole') | |||
| _.each(dcNames, function(dcName) { | |||
| $scope.recentPipelinesByDC[dcName] = $scope.recentPipelinesByDC[dcName] || []; | |||
| $scope.recentPipelinesByDC[dcName].push(build); | |||
| if (isIncompleteBuild(build)) { | |||
| $scope.incompletePipelinesByDC[dcName] = $scope.incompletePipelinesByDC[dcName] || []; | |||
jwforres
approved these changes
Jan 17, 2017
|
[merge] |
|
Evaluated for origin web console merge up to 67285dc |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/922/) (Base Commit: 05093f6) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't show the expanded view (with stages) for pipelines that haven't
started. Since we now have run policy for build configs, it's possible
to queue up several pipeline builds. They take up a lot of space on the
overview when expanded and don't have any stage details until they
actually start running.
Fixes #1097