Let users pause rollouts when editing deployment configs #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwforres
reviewed
Jan 17, 2017
| @@ -356,6 +356,11 @@ <h3 class="with-divider">Environment Variables</h3> | |||
| </div> | |||
| </div> | |||
|
|
|||
| <pause-rollouts-checkbox | |||
| deployment="updatedDeploymentConfig" | |||
| always-visible="true"> | |||
There was a problem hiding this comment.
was this because you can change the triggers within this page? why not show/hide this depending on whether the dc trigger is enabled?
There was a problem hiding this comment.
I thought you might want to pause/resume rollouts in this editor for other reasons (e.g. to keep image change triggers from firing)
|
this needs to be rebased, otherwise LGTM |
jwforres
approved these changes
Jan 19, 2017
Add a checkbox to pause rollouts when making changes to a deployment config (or deployment). This lets you make edits without immediately deploying.
spadgett
force-pushed
the
pause-rollouts-checkbox
branch
from
8fbbfac to
2c89c33
Compare
|
Rebased, no other changes [merge] |
|
Evaluated for origin web console merge up to 2c89c33 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/954/) (Base Commit: 5371b15) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a checkbox to pause rollouts when making changes to a deployment config (or deployment). This lets you make edits without immediately deploying.