-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent mobile table td collapsing issue #1131
Prevent mobile table td collapsing issue #1131
Conversation
In other places, we used a non-breaking space to make sure the table cell had height. For instance, If we have a different solution, we should probably change those to be consistent. |
@@ -123,6 +123,7 @@ | |||
/* Behave like a row */ | |||
border: none; | |||
border-bottom: 1px solid lighten(@table-border-color, 5%); | |||
min-height: 38px; // prevent empty td collapsing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a magic number. Is there any existing variable that makes sense for min-height?
cc @rhamilto |
9b22f5c
to
e665c04
Compare
Updated PR, switched to using non-breaking space to maintain td height |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the non-breaking space is a dirty hack that will only fix this one instance.
I much prefer the CSS approach you took earlier. Rather than setting an absolute value of 38px, can't you calculate that value by summing variables?
I'm good with the CSS fix. Just saying we should remove the |
e665c04
to
5e1aa62
Compare
Updated pr to use min-height calculated. Note: related issue pertaining to switching out other |
[merge] |
Evaluated for origin web console merge up to 5e1aa62 |
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/931/) (Base Commit: 2d9fec8) |
Fixes #1128