-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow special characters in search keywords #1145
Merged
openshift-bot
merged 4 commits into
openshift:master
from
spadgett:highlight-keywords-fix
Jan 19, 2017
Merged
Allow special characters in search keywords #1145
openshift-bot
merged 4 commits into
openshift:master
from
spadgett:highlight-keywords-fix
Jan 19, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly filter and highlight special characters in text filters like the project list and catalog. Fix an issue where project names with special characters didn't display correctly in the create from URL page select.
JS LGTM |
jwforres
approved these changes
Jan 19, 2017
Adjusting highlight color on selected ui-select
Show project names even when there is a display name to highlight search matches in the name. Perform case-insensitive searches.
@jwforres please take a look at the last commit |
LGTM |
[merge] |
Evaluated for origin web console merge up to 326ca53 |
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/945/) (Base Commit: 37d4d78) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly filter and highlight special characters in text filters like
the project list and catalog. Fix an issue where project names with
special characters didn't display correctly in the create from URL page
select.
@rhamilto