Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow special characters in search keywords #1145

Merged
merged 4 commits into from
Jan 19, 2017

Conversation

spadgett
Copy link
Member

Correctly filter and highlight special characters in text filters like
the project list and catalog. Fix an issue where project names with
special characters didn't display correctly in the create from URL page
select.

@rhamilto

Correctly filter and highlight special characters in text filters like
the project list and catalog. Fix an issue where project names with
special characters didn't display correctly in the create from URL page
select.
@spadgett spadgett requested a review from jwforres January 19, 2017 17:16
@spadgett
Copy link
Member Author

@jwforres please take a look at the JS. @rhamilto is going to tweak the mark style for use with ui-select

@jwforres
Copy link
Member

JS LGTM

@spadgett spadgett changed the title [WIP] Allow special characters in search keywords Allow special characters in search keywords Jan 19, 2017
Show project names even when there is a display name to highlight search
matches in the name. Perform case-insensitive searches.
@spadgett
Copy link
Member Author

@jwforres please take a look at the last commit

@jwforres
Copy link
Member

LGTM

@spadgett
Copy link
Member Author

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 326ca53

@openshift-bot
Copy link

openshift-bot commented Jan 19, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/945/) (Base Commit: 37d4d78)

@openshift-bot openshift-bot merged commit f838067 into openshift:master Jan 19, 2017
@spadgett spadgett deleted the highlight-keywords-fix branch January 19, 2017 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants