Add StatefulSets to monitoring #1163

benjaminapetersen · 2017-01-20T18:39:53Z

Progress so far:

I think this is doable today, is just a lot of copy/paste & update. No logs (since we don't have the endpoint) but metrics works.

@jwforres @spadgett

jwforres · 2017-01-20T19:20:19Z

so the interesting problem here is that when metrics isnt enabled there would be nothing to show when the row is expanded :-\

…

On Fri, Jan 20, 2017 at 1:40 PM, Ben Petersen ***@***.***> wrote: @benjaminapetersen <https://github.com/benjaminapetersen> requested your review on: openshift/origin-web-console#1163 <#1163> [WIP] Add StatefulSets to monitoring. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1163 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABZk7WhjMveGVJkltnGM5bBHAeVCdyydks5rUP-IgaJpZM4LpnVF> .

spadgett · 2017-01-20T19:44:28Z

Here's what we show for replica sets:

https://github.com/openshift/origin-web-console/blob/master/app/views/monitoring.html#L248-L252

benjaminapetersen · 2017-01-20T19:47:47Z

TODO yet:

fix the above issue to show something when metrics is not available
fix the dropdown picker for "stateful sets"
fix the replicas count, since it will always be 0 until 1.6

benjaminapetersen · 2017-01-20T20:26:57Z

No logs message:

same fn works to load up the pods for a stateful sets as is used for the replica sets.

benjaminapetersen · 2017-01-20T20:27:06Z

squashed

jwforres · 2017-01-20T20:53:37Z

app/scripts/controllers/monitoring.js

+
+    // TODO: make setStatefulSetLogVars work
+    // logging endpoint for stateful sets coming in the future.
+    var setStatefulSetLogVars = function(set) {


can we just comment out all of this, no point in running code we arent using

jwforres · 2017-01-20T20:54:38Z

app/scripts/controllers/monitoring.js

+          return true;
+        }
+        // TODO: statefulSets don't have status.phase. As far as I understand, they don't age the
+        // way other things age, so perhaps this is irrelevant?


yep i think you are right, I don't think we would hide any statefulsets ever, so you don't need to change anything when the filter is checked/unchecked

good, will wipe out most of this fn then.

jwforres · 2017-01-20T20:56:04Z

app/views/monitoring.html

+                              <small>created <span am-time-ago="set.metadata.creationTimestamp"></span></small>
+                            </div>
+                            <div class="list-group-item-text">
+                              <!-- TODO: is this the right status? -->


probably just needs to be the replica counts like we have in the stateful sets table, we dont have a status for stateful sets

Ok. I got this for the other pages, will see if I can work in in here quick as well.

jwforres · 2017-01-20T20:56:40Z

app/views/monitoring.html

+                          <div class="list-view-pf-additional-info">
+                            <div class="list-view-pf-additional-info-item">
+                              <span class="pficon fa-fw pficon-image"></span>
+                              <!-- TODO: not sure what to do with this, gotta figure it out -->


looks like this is right, if you copied it from the dep stuff should be fine

ha, sorry, that was an early comment I should have removed :)

jwforres · 2017-01-20T20:57:47Z

app/views/monitoring.html

+                    </div>
+                    <div ng-repeat-end ng-if="expanded.statefulSets[set.metadata.name]" class="list-group-expanded-section" ng-class="{'expanded': expanded.statefulSets[set.metadata.name]}">
+
+                      <!-- TODO: add logs once we have logs subresource for statefulSets


honestly i would probably just remove this completely, we dont have logs for replicasets either and it may be awhile before we do, I dont think we left any commented out code for those

works for me, removed.

jwforres · 2017-01-20T20:58:59Z

app/views/monitoring.html

+
+                      <!-- Until the metrics directive pulls the metrics from the time range of the life of the pod, hide the metrics for old stuff -->
+                      <div class="mar-top-lg" ng-if="metricsAvailable">
+                        Logs are not available for stateful sets.


this doesnt seem right, this message only shows up if metricsAvailable is true, you'll still end up with any empty section when metrics arent available

Um, yeah... that doesn't make sense. Fixed.

benjaminapetersen · 2017-01-20T21:40:07Z

Fixed the replicas count as well by counting pods per discussion.

- Supports Metrics - Does not currently support logs

benjaminapetersen · 2017-01-20T21:42:17Z

rebased

jwforres · 2017-01-20T21:59:00Z

[merge]

spadgett · 2017-01-21T19:48:51Z

oc --server https://localhost:8443 patch oauthclient/openshift-web-console -p {"redirectURIs":["https://localhost:9000/"]}
>> Error: The connection to the server localhost:8443 was refused - did you specify the right host or port?

[merge]

jwforres · 2017-01-23T13:35:25Z

[merge]

openshift-bot · 2017-01-23T13:39:08Z

Evaluated for origin web console merge up to aea91f5

openshift-bot · 2017-01-23T13:39:16Z

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/964/) (Base Commit: 448422b)

benjaminapetersen requested a review from jwforres January 20, 2017 18:40

benjaminapetersen force-pushed the statefulset-monitoring branch from 9bf8759 to 875ef42 Compare January 20, 2017 20:26

jwforres requested changes Jan 20, 2017

View reviewed changes

benjaminapetersen changed the title ~~[WIP] Add StatefulSets to monitoring~~ Add StatefulSets to monitoring Jan 20, 2017

Add Stateful Sets to monitoring page

aea91f5

- Supports Metrics - Does not currently support logs

benjaminapetersen force-pushed the statefulset-monitoring branch from 875ef42 to aea91f5 Compare January 20, 2017 21:42

jwforres approved these changes Jan 20, 2017

View reviewed changes

openshift-bot merged commit 880fcfc into openshift:master Jan 23, 2017

benjaminapetersen deleted the statefulset-monitoring branch January 23, 2017 14:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add StatefulSets to monitoring #1163

Add StatefulSets to monitoring #1163

benjaminapetersen commented Jan 20, 2017

jwforres commented Jan 20, 2017 via email

spadgett commented Jan 20, 2017

benjaminapetersen commented Jan 20, 2017 •

edited

Loading

benjaminapetersen commented Jan 20, 2017

benjaminapetersen commented Jan 20, 2017

jwforres Jan 20, 2017

benjaminapetersen Jan 20, 2017

jwforres Jan 20, 2017

benjaminapetersen Jan 20, 2017

jwforres Jan 20, 2017

benjaminapetersen Jan 20, 2017

jwforres Jan 20, 2017

benjaminapetersen Jan 20, 2017

jwforres Jan 20, 2017

benjaminapetersen Jan 20, 2017

jwforres Jan 20, 2017

benjaminapetersen Jan 20, 2017

benjaminapetersen commented Jan 20, 2017 •

edited

Loading

benjaminapetersen commented Jan 20, 2017

jwforres commented Jan 20, 2017

spadgett commented Jan 21, 2017

jwforres commented Jan 23, 2017

openshift-bot commented Jan 23, 2017

openshift-bot commented Jan 23, 2017 •

edited

Loading

Add StatefulSets to monitoring #1163

Add StatefulSets to monitoring #1163

Conversation

benjaminapetersen commented Jan 20, 2017

jwforres commented Jan 20, 2017 via email

spadgett commented Jan 20, 2017

benjaminapetersen commented Jan 20, 2017 • edited Loading

benjaminapetersen commented Jan 20, 2017

benjaminapetersen commented Jan 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benjaminapetersen commented Jan 20, 2017 • edited Loading

benjaminapetersen commented Jan 20, 2017

jwforres commented Jan 20, 2017

spadgett commented Jan 21, 2017

jwforres commented Jan 23, 2017

openshift-bot commented Jan 23, 2017

openshift-bot commented Jan 23, 2017 • edited Loading

benjaminapetersen commented Jan 20, 2017 •

edited

Loading

benjaminapetersen commented Jan 20, 2017 •

edited

Loading

openshift-bot commented Jan 23, 2017 •

edited

Loading