Fix stateful sets replicas count #1165
Conversation
| // we are just using to fix the fact that the replicas count in inaccurate | ||
| watches.push(DataService.watch('pods', context, function(podData) { | ||
| $scope.pods = podData.by('metadata.name'); | ||
| var allOwners = _.toArray($scope.statefulSets); |
There was a problem hiding this comment.
i actually dont think you need to convert it to an array, i think it will accept $scope.statefulSets directly. The only reason we did it on overview is because we have to combine a bunch of different sets of owners
There was a problem hiding this comment.
ok cool, ill nix this
| <replicas | ||
| status="statefulSet.status.replicas" | ||
| spec="statefulSet.spec.replicas" | ||
| disable-scaling="!isScalable()" | ||
| scale-fn="scale(replicas)" | ||
| deployment="statefulSet"> | ||
| </replicas> | ||
| --> | ||
| {{podsForStatefulSet | hashSize}} current / {{statefulSet.spec.replicas}} desired |
There was a problem hiding this comment.
when current === desired we should just say 'X replicas'
There was a problem hiding this comment.
will do, i have this on the other page, easy swap
There was a problem hiding this comment.
Will now be 3/5 replicas or 5 replicas, depending on ===
benjaminapetersen
force-pushed
the
stateful-sets-replicas-count
branch
from
eb4a4a3 to
7288727
Compare
|
squashed |
|
[merge] |
|
Evaluated for origin web console merge up to 7288727 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/962/) (Base Commit: e50c0c2) |
@jwforres this will take care of the Stateful Set list & individual page.
I'll fix it for monitoring in a separate follow-on.