Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the position of the log viewer "Go to End" button by … #1177

Merged
merged 1 commit into from
Jan 25, 2017

Conversation

sg00dwin
Copy link
Member

adjusting its' right alignment to match middle container-fluid edge. At >992 width the middle container margin is wider so the button position needs to adjust.

  • added variables to calc positioning
  • scrollbar width increased 1px so button edge doesn't overhang in Firefox
  • moved related classes to _substructure.less from _core.less

Fixes #1162

screen shot 2017-01-24 at 1 52 42 pm

screen shot 2017-01-24 at 1 50 34 pm

screen shot 2017-01-24 at 1 49 50 pm

Monitoring
screen shot 2017-01-24 at 1 31 19 pm

Chromeless view
screen shot 2017-01-24 at 1 34 27 pm

@spadgett
Copy link
Member

scrollbar width increased 1px so button edge doesn't overhang in Firefox

I remember we picked the scrollbar width to match IE's native scrollbar... Does changing the width cause a similar problem in IE?

@sg00dwin
Copy link
Member Author

I'll double check in browserstack once we get our subscription renewed, it expired yesterday.

@spadgett
Copy link
Member

@sg00dwin It's only one pixel, so I'm not too concerned about it. It would be good to double-check IE when we can, though.

@spadgett
Copy link
Member

[merge]

@spadgett
Copy link
Member

Error: Timed out waiting for the WebDriver server at http://172.18.2.251:45556/wd/hub

@jwforres FYI, I've been seeing this flake more and more lately

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to e90f816

@openshift-bot
Copy link

openshift-bot commented Jan 25, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/985/) (Base Commit: c9474fc)

@jwforres
Copy link
Member

jwforres commented Jan 25, 2017 via email

@openshift-bot openshift-bot merged commit a506596 into openshift:master Jan 25, 2017
@sg00dwin sg00dwin deleted the log-view-scroll-button branch January 25, 2017 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants