Fix error changing route termination to passthrough #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a problem when changing an existing route to passthrough from another termination type. The web console was incorrectly sending certificates (and path if set) in the PUT request even though those inputs were disabled in the form and invalid for passthrough routes.
jwforres
approved these changes
Jan 26, 2017
|
[merge] |
|
Evaluated for origin web console merge up to 192c547 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/990/) (Base Commit: ad2fdea) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a problem when changing an existing route to passthrough from
another termination type. The web console was incorrectly sending
certificates (and path if set) in the PUT request even though those
inputs were disabled in the form and invalid for passthrough routes.