Let users specify insecureEdgeTerminationPolicy for other termination types #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwforres
requested changes
Jan 26, 2017
| </div> | ||
| <div ng-if="routeForm.insecureTraffic.$error.passthrough" class="has-warning"> | ||
| <span class="help-block"> | ||
| Passthrough routes can't have insecure traffic policy <var>Allow</var>. |
There was a problem hiding this comment.
Passthrough routes can't use the insecure traffic policy Allow
… types Previously we only let users specify the insecureEdgeTerminationPolicy for edge-terminated routes. Allow it for any termination type. The value `Allow` should be disabled for passthrough routes, however.
spadgett
force-pushed
the
relax-route-validation
branch
from
9b574d3 to
f2dbce7
Compare
|
@jwforres thanks, updated |
jwforres
approved these changes
Jan 27, 2017
|
[merge] |
|
Evaluated for origin web console merge up to f2dbce7 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/991/) (Base Commit: 960a94b) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only let users specify the insecureEdgeTerminationPolicy for edge-terminated routes. Allow it for any termination type. The value
Allowshould be disabled for passthrough routes, however.cc @smarterclayton