Add tech preview header to StatefulSets list & detail page #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the placement has gotten off in the second screenshot
…On Jan 31, 2017 11:38 AM, "Ben Petersen" ***@***.***> wrote:
@benjaminapetersen <https://github.com/benjaminapetersen> requested your
review on: openshift/origin-web-console#1198
<#1198> Add tech
preview header to StatefulSets list & detail page.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1198 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZk7VaTfgVWaE7217OuoK2vVAoAJMO3ks5rX2OMgaJpZM4Ly3gm>
.
|
|
Hmm... yeah, one has |
|
@jwforres actually, its just that the first one has the scrollbar but I didn't include it in the screenshot.
|
benjaminapetersen
force-pushed
the
statefulset-tech-preview
branch
from
1f2c5cc to
3207a37
Compare
|
Adjusted list view. |
|
still doesn't seem right, that is adding a bunch of top whitespace that
wasnt there before
…On Tue, Jan 31, 2017 at 5:08 PM, Ben Petersen ***@***.***> wrote:
[image: screen shot 2017-01-31 at 5 03 54 pm]
<https://cloud.githubusercontent.com/assets/280512/22486550/e97b6b8c-e7d7-11e6-892c-cc509064e91f.png>
Adjusted list view.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1198 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZk7Rskzp_B0t7YITZTUSj9FM4s_J6pks5rX7D6gaJpZM4Ly3gm>
.
|
benjaminapetersen
force-pushed
the
statefulset-tech-preview
branch
from
3207a37 to
1f4b1cd
Compare
|
😁😁😁 |
jwforres
approved these changes
Feb 1, 2017
|
thanks! [merge] |
|
@sspeiche tech preview indicator is going in |
|
Evaluated for origin web console merge up to 1f4b1cd |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1003/) (Base Commit: 7b83464) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jwforres @spadgett