Warn when editing YAML did not change the object #1222
Conversation
|
what happens if someone modifies something else in etcd between the time Edit YAML is opened and when you saved? resourceVersion isn't per object |
|
Just tested: it still works. We're checking that the resource version hasn't changed at all, which seems to be the case always if I add an unrecognized property. |
|
@jwforres travis is complaining about dist, and I'm not sure why |
|
cleared the caches and told it to rebuild, if that doesn't work maybe try cleaning your deps? its vendor.js its complaining about, maybe some dependency has changed. |
Show a warning and stay on the edit YAML page when no edits were applied. This can happen when trying to add a property that is not recognized or when misspelling a field name.
spadgett
force-pushed
the
no-changes-warning
branch
from
9d32e60 to
6bffb9e
Compare
|
Updated to fix dist |
|
[merge] |
|
Evaluated for origin web console merge up to 6bffb9e |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1012/) (Base Commit: aac7d52) |
Show a warning and stay on the edit YAML page when no edits were applied. This can happen when trying to add a property that is not recognized or when misspelling a field name.
See #1221