Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show failed pods in pod donut #1223

Merged
merged 1 commit into from
Feb 6, 2017

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Feb 6, 2017

Prevent evicted and other failed pods from showing up in the pod donut.

cc @derekwaynecarr

Copy link
Member

@jwforres jwforres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you'll need to rebase / drop the vendor.js change after your other PR merges.

@spadgett
Copy link
Member Author

spadgett commented Feb 6, 2017

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 74b7b71

@openshift-bot
Copy link

openshift-bot commented Feb 6, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1014/) (Base Commit: 68c6590)

@openshift-bot openshift-bot merged commit fbc282d into openshift:master Feb 6, 2017
@spadgett spadgett deleted the evicted-pods branch February 22, 2017 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants