Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing top margin causing unnecessary above the .log-header on the monitoring page. #1238

Merged
merged 1 commit into from
Feb 24, 2017

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Feb 9, 2017

Fixes #1233

screen shot 2017-02-09 at 3 03 43 pm

screen shot 2017-02-09 at 3 04 13 pm

@spadgett
Copy link
Member

spadgett commented Feb 9, 2017

Can you check a pod with multiple containers?

oc create -f https://raw.githubusercontent.com/openshift-qe/v3-testfiles/master/pods/pod_with_two_containers.json

@spadgett spadgett self-assigned this Feb 10, 2017
@spadgett spadgett added this to the 1.6.0 milestone Feb 10, 2017
@sg00dwin sg00dwin force-pushed the log-header-space-issue1233 branch 2 times, most recently from 5263b92 to 9cc9c39 Compare February 10, 2017 21:47
@sg00dwin
Copy link
Member Author

sg00dwin commented Feb 10, 2017

Updated PR so that .log-header containing a ui-select has adequate spacing between it and the logs.

screen shot 2017-02-10 at 4 36 16 pm

screen shot 2017-02-24 at 1 34 24 pm

…monitoring page.

Adding class to adjust spacing when ui-select is shown
Fixes openshift#1233
@sg00dwin sg00dwin force-pushed the log-header-space-issue1233 branch from 9cc9c39 to 65b81a8 Compare February 23, 2017 21:58
@sg00dwin
Copy link
Member Author

@spadgett anything needed for this to move forward?

@spadgett
Copy link
Member

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 65b81a8

@openshift-bot
Copy link

openshift-bot commented Feb 24, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1111/) (Base Commit: ee3fd10)

@openshift-bot openshift-bot merged commit cdb8a24 into openshift:master Feb 24, 2017
@sg00dwin sg00dwin deleted the log-header-space-issue1233 branch February 27, 2017 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants