Fix bug where margin is inconsistent on .table inside .table-responsive #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
approved these changes
Feb 14, 2017
|
[merge] |
|
[Test]ing while waiting on the merge queue |
|
Even though travis was happy when the commit was pushed, jenkins is now saying the dist for main.css isn't right. May need to try clean/install/build and see if you get a diff |
openshift-bot
added
the
needs-rebase
rhamilto
removed
the
needs-rebase
|
[merge] |
|
[test] |
|
[merge] |
1 similar comment
|
[merge] |
|
@rhamilto looks like its failing on dist/main.css |
Fixes #1187 The relevant bug fix lines are 218-240. The rest of the changes in _tables.less are refactoring and cleanup to align with CSS code standards. Also adding .table-bordered to the instances that lacked it so .tables are styled consistently.
|
Evaluated for origin web console test up to b740404 |
|
[merge] |
|
Evaluated for origin web console merge up to b740404 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1096/) (Base Commit: 76d914e) |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1095/) (Base Commit: 42c67c2) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1187
The relevant bug fix lines are 218-240. The rest of the changes in
_tables.less are refactoring and cleanup to align with CSS code
standards.
Also adding .table-bordered to the instances that lacked it so .tables
are styled consistently.