Bug 1427084 - Fix problem showing project usage for cluster quota #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we switched from a `clusterQuotas` map to a `clusterQuotas` array for sorting, we incorrectly keyed the `namespaceUsageByClusterQuota` map by array index instead of namespace. This prevented the project usage for a cluster quota from displaying. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1427084
benjaminapetersen
approved these changes
Feb 27, 2017
|
Thanks @benjaminapetersen [merge] |
|
Evaluated for origin web console merge up to 71d4685 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1118/) (Base Commit: a941af6) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we switched from a
clusterQuotasmap to aclusterQuotasarrayfor sorting, we incorrectly keyed the
namespaceUsageByClusterQuotamapby array index instead of namespace. This prevented the project usage
for a cluster quota from displaying.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1427084
@benjaminapetersen ptal
@jwforres fyi