Add catalog to web console #1389
Conversation
|
Requires openshift/origin-web-catalog#73 |
| @@ -70,6 +70,10 @@ angular.module("openshiftConsole") | |||
| return "project/" + encodeURIComponent(projectName) + "/overview"; | |||
| }, | |||
|
|
|||
| toProjectList: function(){ | |||
| $location.path('projects'); | |||
There was a problem hiding this comment.
this should always work whether catalog is turned on or not, maybe we should add a redirect from projects to / when the landing page isn't enabled
| }; | ||
| if (_.get(window, 'OPENSHIFT_CONSTANTS.ENABLE_TECH_PREVIEW_FEATURE.service_catalog_landing_page')) { | ||
| landingPageRoute = { | ||
| templateUrl: 'views/landing-page.html', |
There was a problem hiding this comment.
Might want to use home.html rather than landing-page.html just for the look of the URL to users.
There was a problem hiding this comment.
The url should just be /console. Although maybe I shouldn't name the controller the same as the component
There was a problem hiding this comment.
users should never see this URL, our templates are embedded into $templateCache at build time
spadgett
force-pushed
the
mall-test
branch
4 times, most recently
from
dad8b42 to
aa128ce
Compare
spadgett
changed the title
|
[merge] |
|
Evaluated for origin web console merge up to f43fbbe |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1208/) (Base Commit: 3483dc3) |
@jwforres @jeff-phillips-18 FYI, not ready to merge, but it's working