Create service bindings from the overview #1395
Conversation
|
Extremely rough first pass at this, just getting something started. Note: does not actually set PodPreset yet but should be trivial to add that piece once we can send it to the API.
|
|
Nice work @jwforres! No that I see this, I wonder if it might make sense to add some text on the first step about what it means to create a binding. The design sort of explains it after you've done it, which is backwards. |
|
ship it |
| var newestReady; | ||
| var newestNotReady; | ||
| _.each(ctrl.serviceInstances, function(instance) { | ||
| var ready = _.get(statusCondition(instance, 'Ready'), 'status', 'False') === 'True'; |
There was a problem hiding this comment.
Shouldn't need to provide a default since you're checking === 'True' anyway.
var ready = _.get(statusCondition(instance, 'Ready'), 'status') === 'True';| } | ||
|
|
||
| // wait till both service instances and service classes are available so that the sort is stable and items dont jump around | ||
| if (changes.serviceInstances && ctrl.serviceClasses || changes.serviceClasses && ctrl.serviceInstances) { |
There was a problem hiding this comment.
I think this needs to be...
if ((changes.serviceInstances || changes.serviceClasses) && ctrl.serviceClasses && ctrl.serviceInstances) {
// ...
}$onChanges is called for initial values, which might be uninitialized.
| // TODO - would be better if generateName could take in an optional maxlength | ||
| var truncatedSvcInstanceName = _.trunc(serviceInstanceName, DNS1123_SUBDOMAIN_VALIDATION.maxlength - 6); | ||
| ctrl.generatedSecretName = generateName(truncatedSvcInstanceName + '-'); | ||
| let binding = { |
| @@ -9,3 +9,12 @@ | |||
| font-size: @donut-font-size-big * .75; // ~ 22.5px; | |||
| font-weight: 300; | |||
| } | |||
|
|
|||
| .wizard-pf-steps-indicator .wizard-pf-step-number { | |||
There was a problem hiding this comment.
TODO to remove when we update Patternfly?
| <button | ||
| type="button" | ||
| class="btn btn-primary wizard-pf-next" | ||
| ng-disabled="ctrl.currentStep.id === 'results'" |
There was a problem hiding this comment.
Should we hide the button on the last page instead of just disable? Currently what we do for order service.
| <div class="sub-title"> | ||
| <h3><span class="pficon pficon-ok mar-right-sm"></span>Configuration Created</h3> | ||
| The binding operation created the secret | ||
| <a ng-href="{{ctrl.generatedSecretName | navigateResourceURL : 'Secret' : ctrl.target.metadata.namespace}}">{{ctrl.generatedSecretName}}</a> |
There was a problem hiding this comment.
Trying to decide if it's a worth a canI check here. Presumably if you can bind, you can view secrets.
| <input type="radio" ng-model="ctrl.serviceToBind" value="{{serviceInstance.metadata.name}}"> | ||
| {{ctrl.serviceClasses[serviceInstance.spec.serviceClassName].osbMetadata.displayName || serviceInstance.spec.serviceClassName}} | ||
| <span ng-if="(serviceInstance | statusCondition : 'Ready').status !== 'True'" class="mar-left-sm"> | ||
| <span class="pficon pficon-info" data-content="This service is not yet ready. If you bind to it, then the binding will be pending until the service is ready." class="pficon pficon-warning-triangle-o" data-toggle="popover" data-trigger="hover"></span> |
There was a problem hiding this comment.
You have class twice on this element.
jwforres
changed the title
|
review comments addressed, built, and squashed |
|
Suspect it's something with adding the catalog to the module dependency list, let's try Jenkins [test] |
|
karma.conf.js was pretty outdated as far as the list of dependency JS files to load, went ahead and made it match the state of index.html |
|
Evaluated for origin web console test up to 4f53b14 |
|
travis is passing now [merge] |
|
Evaluated for origin web console merge up to 4f53b14 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1201/) (Base Commit: 722fec3) |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1200/) (Base Commit: 722fec3) |
No description provided.