Add oc login quick command to help dropdown
#1788
Conversation
|
Screenshot: @jwforres I can't say how often I hate having to go to the Command Line page, just to login. And the problem is compounded when using multiple clusters, as the OpenShift Online users will soon be doing when switching between Starter and Pro clusters. I think something like this would go a long way to helping ease some of that pain. |
|
@jwforres Do you think this is something that could be beneficial or belong in origin? |
|
I'd rather have a normal menu item with text like "Copy Login Command" above "About." clipboard.js supports copying without showing the input. My only concern is that we don't give a warning about the access tokens this way. We might need a modal or toast notification to warn about this after the copy. |
|
Ohh, good idea! Lemme work on that =)
|
|
Might be better under the user menu as well. That's probably where I would look as a new user. @jwforres any objections with the proposed changes? |
wgordon17
force-pushed
the
login-shortcut
branch
2 times, most recently
from
6f60a06 to
e22f9eb
Compare
|
Updated screenshots: Copy Login Command option Successful copy event Token warning |
|
@spadgett Something like that ^^? |
openshift-bot
added
the
needs-rebase
wgordon17
force-pushed
the
login-shortcut
branch
from
e22f9eb to
fa7a981
Compare
wgordon17
removed
the
needs-rebase
wgordon17
force-pushed
the
login-shortcut
branch
from
fa7a981 to
eb97643
Compare
Signed-off-by: Will Gordon <[email protected]>
wgordon17
force-pushed
the
login-shortcut
branch
from
eb97643 to
23d188b
Compare
|
[test] |
|
Evaluated for origin web console test up to 23d188b |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/66/) (Base Commit: 2ecf744) (PR Branch Commit: 23d188b) |
|
@wgordon17 Sorry for letting this sit for so long. I noticed that the case of the menu item "Copy Login Command" doesn't match "Log out" below. I might change the primary text of the toast to confirm that the command was successfully copied to the clipboard, and then add the warning as the detail text below (or as a separate alert). Maybe it should be a success alert since the copy worked. @openshift/team-ux-review Thoughts on this change? Copying the login command is pretty common, and it's a bit hard to find on the "Command Line Tools" page. |
|
@spadgett Completely makes sense! Just let me know your updates here and I can re-commit =) @openshift/team-ux-review The other reason for this besides being hard to find, is that to get the login command requires navigating to an entirely separate page. With how common this is, it would be ideal to get the login command without any navigation necessary! |
|
@spadgett We should be using Headline Capitalization here, so I think that @wgordon17 did it right. We should have "Log out" changed to "Log Out". As for the location, yes I agree under the user menu makes more sense. We did get a comment during a review this past week that they wish we would allow the ability to disable access to this. Should we cover this in this PR as well, or should I open a separate issue @spadgett ? |
| NotificationsService.addNotification({ | ||
| id: 'copied_to_clipboard_toast_error', | ||
| type: 'error', | ||
| message: 'Unable to copy.' |
There was a problem hiding this comment.
Prob should say Unable to copy token or something just a touch more specific?
|
[merge] |
|
Evaluated for origin web console merge up to 23d188b |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/216/) (Base Commit: 164ae0a) (PR Branch Commit: 23d188b) |
@serenamarie125 I opened #2107 to let admins disable copy login command. |
Signed-off-by: Will Gordon [email protected]