Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for landing page bug where .landing wasn't positioned correctly #2000

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Fix for landing page bug where .landing wasn't positioned correctly #2000

merged 1 commit into from
Sep 6, 2017

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Sep 1, 2017

No description provided.

@rhamilto rhamilto requested a review from spadgett September 1, 2017 19:31
benjaminapetersen
benjaminapetersen approved these changes Sep 1, 2017
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better to me, I can see the tabs & things now! 👍

@spadgett
Copy link
Member

spadgett commented Sep 1, 2017

[merge][severity: blocker]

@spadgett
Copy link
Member

spadgett commented Sep 1, 2017

Looks like this might be flake #1685

  1. User adds an image stream to a project after creating a new project using the Import YAML tab should process and create the images in the image stream
  • ElementNotVisibleError: Element is not currently visible and so may not be interacted with

[merge][severity: blocker]

@spadgett
Copy link
Member

spadgett commented Sep 4, 2017

[merge][severity: blocker]

@spadgett
Copy link
Member

spadgett commented Sep 4, 2017

Looks like this is the test failure:

Driver info: driver.version: unknown

@rhamilto rhamilto closed this Sep 5, 2017
@rhamilto rhamilto deleted the landing-page-fix branch September 5, 2017 18:24
@rhamilto rhamilto restored the landing-page-fix branch September 5, 2017 18:43
@rhamilto rhamilto reopened this Sep 5, 2017
@spadgett
Copy link
Member

spadgett commented Sep 6, 2017

[merge][severity: blocker]

@spadgett
Copy link
Member

spadgett commented Sep 6, 2017

[merge][severity:blocker]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 94a7a95

@openshift-bot
Copy link

openshift-bot commented Sep 6, 2017 •
edited
Loading

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/115/) (Base Commit: 4f8b2cf) (PR Branch Commit: 94a7a95) (Extended Tests: blocker)

@openshift-bot openshift-bot merged commit 0e7d693 into openshift:master Sep 6, 2017
@rhamilto rhamilto deleted the landing-page-fix branch September 6, 2017 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

@spadgett spadgett spadgett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhamilto @spadgett @openshift-bot @benjaminapetersen