Show application kind when add to application dropdown is open #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeff-phillips-18 It looks like my fix in openshift/origin-web-common#189 was bad and some RCs are showing up that shouldn't. Debugging that now. |
Fixed by openshift/origin-web-common#197 |
jeff-phillips-18
approved these changes
Sep 22, 2017
|
@jeff-phillips-18 Actually I might switch this to use ui-select groups like we do for the env value from picker |
On the secret page, when clicking "Add to Application", show the kind when the "Application" dropdown is open. Currently the kind is only displayed after you pick an item.
spadgett
force-pushed
the
add-to-application-show-kind
branch
from
3284ad9 to
1468e2d
Compare
|
OK changed to group by kind like other selects:
|
|
@jeff-phillips-18 another look? |
jeff-phillips-18
approved these changes
Sep 22, 2017
|
[merge] |
|
Evaluated for origin web console merge up to 1468e2d |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/252/) (Base Commit: 6bac146) (PR Branch Commit: 1468e2d) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the secret page, when clicking "Add to Application", show the kind
when the "Application" dropdown is open. Currently the kind is only
displayed after you pick an item.
Before:
After: