Update DeploymentConfig controller to use getPreferredVersion #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
requested changes
Sep 26, 2017
| @@ -8,7 +8,7 @@ <h1 class="contains-actions"> | |||
| <div class="pull-right dropdown" ng-if="deploymentConfig" ng-hide="!('deploymentConfigs' | canIDoAny)"> | |||
There was a problem hiding this comment.
We should be updating the canIDoAny checks to use the same resource versions as the actions
|
We'll also want to update the health check URL to use the group from preferred version on this PR |
benjaminapetersen
force-pushed
the
bpetersen/trello/api-groups/deployment-configs
branch
from
b06a534 to
f96ece2
Compare
benjaminapetersen
changed the title
|
Just rebased & caught this one up w/the other PRs re: |
spadgett
approved these changes
Sep 27, 2017
openshift-bot
added
the
needs-rebase
benjaminapetersen
force-pushed
the
bpetersen/trello/api-groups/deployment-configs
branch
from
f96ece2 to
4428773
Compare
|
rebased |
|
[merge] |
|
Evaluated for origin web console merge up to 4428773 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/288/) (Base Commit: 36bd0fb) (PR Branch Commit: 4428773) |
benjaminapetersen
deleted the
bpetersen/trello/api-groups/deployment-configs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on web-common PR 201 and web-common PR 202