-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overview instance row improvements #2174
Overview instance row improvements #2174
Conversation
Looks good. I wonder if we shouldn't think about changing "Learn More" to "View Documentation" so that it's clearer where that link goes. |
We can do that. Should we change the wizard link text, too? It currently says "Learn More" |
I think in the wizard link too. "Learn More" is vague. |
OK, makes sense. I'll tackle the catalog change in a separate PR since it's another repo anyway. |
Not suggesting we tackle this now, but we use "Learn More" to link to openshift documentation throughout the console. But here I think there's value in making the distinction between documentation and support clear. |
@ncameronbritt I agree. It's only in one place in the catalog, so I just made the change there, too. |
02eab2a
to
43e8d6a
Compare
Updated the link text and switched to the |
@spadgett I know I already approved, but I think I like the larger font size for those links. I feel like they serve a slightly different function in this context as the other "learn more" links that we have in the console. |
* Show documentation URL * Show support URL * Add a delete action to failed deployment alerts * Truncate long text in alert messages
43e8d6a
to
2bd951f
Compare
OK, back to normal font size with some small fixes for mobile styles. |
[merge] |
Evaluated for origin web console merge up to 2bd951f |
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/273/) (Base Commit: c6db605) (PR Branch Commit: 2bd951f) |
@rhamilto @ncameronbritt