-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show "Service Instance" in Other Resources list #2199
Don't show "Service Instance" in Other Resources list #2199
Conversation
Since we have a dedicated page for service instances now, don't show it in the other resources list.
case "Route": | ||
case "Secret": | ||
case "Service": | ||
case "ServiceInstance": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benjaminapetersen I sorted the list, but the only change is adding ServiceInstance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good... this is kind of an awful switch statement huh? 😄
[merge] |
case "Route": | ||
case "Secret": | ||
case "Service": | ||
case "ServiceInstance": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good... this is kind of an awful switch statement huh? 😄
Opened flake #2200 |
[merge] |
[test] |
[merge] |
[test] |
1 similar comment
[test] |
Evaluated for origin web console test up to 1bce0af |
[merge] |
Origin Web Console Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/277/) (Base Commit: a9de5c9) (PR Branch Commit: 1bce0af) |
[merge] |
Evaluated for origin web console merge up to 1bce0af |
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/312/) (Base Commit: 6ef0e8b) (PR Branch Commit: 1bce0af) |
Since we have a dedicated page for service instances now, don't show it in the other resources list.