Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Membership updates to correct broken layouts when multiple roles assigned #2344

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Membership updates to correct broken layouts when multiple roles assigned #2344

merged 1 commit into from
Oct 23, 2017

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Oct 23, 2017 •
edited
Loading

Overall code cleanup
Fixes #1219

@sg00dwin is the commit author.

@spadgett spadgett requested a review from rhamilto October 23, 2017 15:49
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 23, 2017
@spadgett
Copy link
Member Author

Replaces #2283

Same as #2283 with dist rebuilt

@spadgett spadgett mentioned this pull request Oct 23, 2017
Closed
@spadgett spadgett removed the request for review from rhamilto October 23, 2017 16:18
@spadgett spadgett added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2017
@spadgett
Copy link
Member Author

Adding lgtm label since #2283 is already approved

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit da4b76f into openshift:master Oct 23, 2017
@sg00dwin
Copy link
Member

Thanks @spadgett

@sg00dwin sg00dwin mentioned this pull request Jan 16, 2018
Closed
sg00dwin added a commit to sg00dwin/origin-web-console that referenced this pull request Feb 16, 2018
@sg00dwin
Updates to membership page to prevent breaking. This is a back port o…
92573e0 
…f an initial fix that went in 3.7.

Original pr openshift#2344

Fixes bug https://bugzilla.redhat.com/show_bug.cgi?id=1545089
@sg00dwin sg00dwin mentioned this pull request Feb 16, 2018
Merged
openshift-merge-robot added a commit that referenced this pull request Feb 19, 2018
@openshift-merge-robot
Merge pull request #2807 from sg00dwin/membership-fix-3.6
ceae162 
Automatic merge from submit-queue.

Updates to membership page to prevent breaking. This is a back port of an initial fix that went in 3.7.

Original pr #2344

Fixes bug https://bugzilla.redhat.com/show_bug.cgi?id=1545089

![localhost_9000_dev-console_oauth 9](https://user-images.githubusercontent.com/1874151/36327571-fa272b0c-132c-11e8-8f69-c60e73852078.png)
![localhost_9000_dev-console_oauth 8](https://user-images.githubusercontent.com/1874151/36327572-fa373060-132c-11e8-9790-0a5710a032ea.png)
![localhost_9000_dev-console_oauth 7](https://user-images.githubusercontent.com/1874151/36327573-fa4a8ca0-132c-11e8-8787-cf0904b35ac2.png)
![localhost_9000_dev-console_oauth 6](https://user-images.githubusercontent.com/1874151/36327574-fa5e43c6-132c-11e8-8579-c5336f9b1015.png)
![localhost_9000_dev-console_oauth 5](https://user-images.githubusercontent.com/1874151/36327576-fa738cc2-132c-11e8-99aa-45d7fcbaeef3.png)
![localhost_9000_dev-console_oauth 4](https://user-images.githubusercontent.com/1874151/36327577-fa859692-132c-11e8-99a8-fa45a750d731.png)
![localhost_9000_dev-console_oauth 3](https://user-images.githubusercontent.com/1874151/36327578-fa9a3b9c-132c-11e8-9c7c-245c56c2bf8e.png)
![localhost_9000_dev-console_oauth 2](https://user-images.githubusercontent.com/1874151/36327579-fab6910c-132c-11e8-9f12-7669d95c7e8e.png)
![localhost_9000_dev-console_oauth 1](https://user-images.githubusercontent.com/1874151/36327580-facc2274-132c-11e8-873e-2b561005bf71.png)
![localhost_9000_dev-console_oauth](https://user-images.githubusercontent.com/1874151/36327581-fade5732-132c-11e8-9acc-5e977ce5d6d9.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spadgett @openshift-merge-robot @sg00dwin @openshift-ci-robot