Adding "Run on OpenShift" functionality #884

rhamilto · 2016-11-16T21:20:30Z

Proposed image stream query string params:

imageStream (required)
imageTag (required)
namespace (optional, but if not specified, defaults to 'openshift')
name (optional)
sourceURI (optional)
sourceRef (optional)
contextDir (optional)

Proposed template query string params:

template (required)
templateParamsMap (optional)
namespace (optional, but if not specified, defaults to 'openshift')

Testing URLs:

create?name=nodejs-edited&imageStream=nodejs&imageTag=4&sourceURI=https:%2F%2Fytb.ewangdian.workers.dev%2Fopenshift%2Fnodejs-ex.git-edited&sourceRef=master-edited&contextDir=%2F-edited

create?template=nodejs-mongodb-example&templateParamsMap=%7B"SOURCE_REPOSITORY_URL":"https:%2F%2Fytb.ewangdian.workers.dev%2Fopenshift%2Fnodejs-ex.git-edited"%7D

Screenshots:

User has existing project(s) and can create new project(s)

User has no project(s), but can create new project(s)

User has existing project(s), but cannot create new project(s)

User has no existing project(s) nor can create new project(s)

Wondering if the messaging at the bottom is obvious enough? This shouldn't be a common case, but still...

@jwforres or @spadgett, PTAL.

spadgett · 2016-11-17T17:10:03Z

For query parameter names, I think we should align with the API fields where we can. Proposing

contextDir instead of contextDirectory
sourceURI (API field is source.git.uri)
sourceRef (API field is source.git.ref)
app instead of appName (matching the label key)

Can't decide between sourceURI and gitURI.

We might talk about the best way to handle template parameters. JSON is reasonable, but it's a bit hard to build that URL by hand. (I know I suggested JSON before :)

rhamilto · 2016-11-17T18:19:33Z

Great suggestions, @spadgett. I've implemented your proposed changes. I favor sourceURI as it seems more future proof.

@benjaminapetersen and I debated the JSON template params, but decided to go with it since it not only keeps the code simpler, but it also seems simpler with regard to how to construct the query string param since you're overriding template-defined JSON objects with query string-ified JSON objects (URL-building complications aside, which really isn't that bad as the browser will do the bracket escaping for you).

Thoughts?

benjaminapetersen · 2016-11-17T21:53:53Z

Agree on making the params match, that makes sense.
I'd be up for exploring alternates to the JSON syntax in the url, jQuery.param() works fine to create urls with params & I expect many people are familiar with it. example: http://codepen.io/benjaminapetersen/pen/NbbMjJ?editors=0010 (though it will turn a nested object into [object Object]). Hopefully our API can be simple/familiar.

spadgett · 2016-11-18T20:26:59Z

app/scripts/constants.js

-  ]
+  ],
+  // 'openshift' should always be included
+  CREATE_FROM_URL_WHITELIST: ['openshift','run-on-openshift']


I think we should leave this just ['openshift'] by default.

spadgett · 2016-11-18T20:31:01Z

app/scripts/controllers/createFromURL.js

+      if (createDetails.imageStream && createDetails.template) {
+        showInvalidResource();
+      } else if (!(createDetails.imageStream) && !(createDetails.template)) {
+        alertResourceRequired();


We typically use Navigate.toErrorPage() for these types of errors (invalid or conflicting route params)

That was an intentional decision to facilitate the creation of URLs. By throwing an alert on the current page, we can give feedback on specific things that are incorrect while maintaining the context of the query string in the address bar. Do you disagree?

@rhamilto So the idea is that I can tweak the URL in the location bar until I get it right? Makes sense.

Is the rest of the page blank? How does that look?

Is the rest of the page blank? How does that look?

Yep. It looks like a blank page. I wasn't sure what else to include since it's hard to know what the user is trying to do. Thoughts?

Maybe some text with help building the URL? Or a link to the docs when they're written?

spadgett · 2016-11-18T20:35:24Z

app/scripts/controllers/createFromURL.js

+      createWithProject: function(project) {
+        $location
+          .url('/project/' + (project ||  $scope.selected.project.metadata.name) + '/create/' + ($routeParams.imageStream ? 'fromimage' : 'fromtemplate'))
+          .search(createDetails);


We have this URL built in a few places. Probably want to consolidate it in Navigate service (and have filters call the service when needed). See

https://github.com/spadgett/origin-web-console/blob/2c15578e8963210ce91e795ff515f9c845883940/app/scripts/services/navigate.js#L72-L85

https://github.com/spadgett/origin-web-console/blob/2c15578e8963210ce91e795ff515f9c845883940/app/scripts/filters/resources.js#L619-L644

spadgett · 2016-11-18T20:40:33Z

app/scripts/controllers/createFromURL.js

+      $scope.noProjects = (_.isEmpty($scope.projects));
+    });
+
+    // copied from app/scripts/controllers/projects.js


Move into ProjectsService so we have the logic in one place?

spadgett · 2016-11-18T20:42:25Z

app/scripts/controllers/createFromURL.js

+      invalidResource:'Image streams and templates cannot be combined.',
+      invalidTemplate: _.template('The requested template "<%= template %>" is not valid.'),
+      resourceRequired: 'A valid image stream or template is required.'
+    };


Some of these are templates, and some are just strings. I'm not sure I like mixing them in the same object because you have no way to know which is which where they're called. Is this really better than just inlining the messages? Then there's no confusion.

spadgett · 2016-11-18T20:46:08Z

app/scripts/controllers/newfromtemplate.js

@@ -355,6 +354,13 @@ angular.module('openshiftConsole')
            $scope.parameterDisplayNames[parameter.name] = parameter.displayName || parameter.name;
          });

+          _.each($scope.template.parameters, function(parameter) {
+            var found = _.find(JSON.parse($routeParams.templateParamsMap), function(param){


Need to catch the exception on JSON parse failures. This is not JSON we're generating, so it might have syntax errors.

spadgett · 2016-11-18T20:47:29Z

app/scripts/controllers/newfromtemplate.js

+          _.each($scope.template.parameters, function(parameter) {
+            var found = _.find(JSON.parse($routeParams.templateParamsMap), function(param){
+              return param.name === parameter.name;
+            });


Can use the shorthand (where params is the parsed JSON)

_.find(params, { name: parameter.name });

Any reason to not make the JSON a map? For example,

{ "SOURCE_URL_REPOSITORY": "http://github.com/openshift/origin-ruby-example" }

https://github.com/openshift/openshift-ansible/blob/master/roles/openshift_examples/files/examples/v1.4/quickstart-templates/nodejs-mongodb.json#L364 If we do that, then users can only override name and value key values. If we leave it as is, they can override any key values they choose. Do we want to restrict to only name and value values?

Do we want to restrict to only name and value values?

Yeah, I don't think they should be able to change anything other than the value for an existing parameter. We should probably show an error if they give the name that does not match a param in the template.

spadgett · 2016-11-18T20:55:39Z

app/scripts/directives/createProject.js

+        if(!($scope.submitButtonLabel)) {
+          $scope.submitButtonLabel = 'Create';
+        }
+        $scope.createProject = function() {


We typically make the directive just the editor that takes in the object and updates it, then let the controller call create and handle errors.

spadgett · 2016-11-18T20:57:12Z

app/views/create-from-url.html

+                            <ui-select-match placeholder="Project name">
+                              {{$select.selected.metadata.name}}
+                            </ui-select-match>
+                            <ui-select-choices repeat="project in projects | toArray | filter : { metadata: { name: $select.search } } | orderBy : 'metadata.name'">


Better to convert to an array / sort once in the controller.

Should we match keywords on display name as well?

Should we match keywords on display name as well?

Or should we display displayName in the dropdown if it exists?

prob should show it instead of name, but search both fields for match?

spadgett · 2016-11-18T20:58:45Z

app/views/create-from-url.html

+                        <ui-select-match placeholder="Project name">
+                          {{$select.selected.metadata.name}}
+                        </ui-select-match>
+                        <ui-select-choices repeat="project in projects | toArray | filter : { metadata: { name: $select.search } } | orderBy : 'metadata.name'">


Same comment about filter and sorting as line 43.

jwforres · 2016-11-22T14:37:27Z

Yes we should use display name when picking a project here. You'll need
the same logic we use for the main project dropdown, since you have to
handle duplicate display names.

On Tue, Nov 22, 2016 at 9:29 AM, Robb Hamilton [email protected]
wrote:

@rhamilto commented on this pull request.

In app/views/create-from-url.html
#884:

                     {{$select.selected.metadata.name}}

```
                   </ui-select-match>
```

                   <ui-select-choices repeat="project in projects | toArray | filter : { metadata: { name: $select.search } } | orderBy : 'metadata.name'">

                     <div ng-bind-html="project.metadata.name | highlight : $select.search"></div>

                   </ui-select-choices>

```
                 </ui-select>
```
```
               </div>
```

               <div ng-if="!noProjects && canCreateProject">

```
                 <uib-tabset>
```
```
                   <uib-tab>
```

                     <uib-tab-heading>Choose Existing Project</uib-tab-heading>

                     <ui-select ng-model="selected.project">

                       <ui-select-match placeholder="Project name">

                         {{$select.selected.metadata.name}}

                       </ui-select-match>

                       <ui-select-choices repeat="project in projects | toArray | filter : { metadata: { name: $select.search } } | orderBy : 'metadata.name'">

Should we match keywords on display name as well?

Or should we display displayName in the dropdown if it exists?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#884, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABZk7YwhzNn3JKpw4JUwocnCbjiAZAYqks5rAvxbgaJpZM4K0eNa
.

rhamilto · 2016-11-22T14:53:37Z

rhamilto · 2016-11-22T21:24:41Z

@spadgett, I believe @benjaminapetersen and I addressed your comments, but a few additional TODOs remain. So we're not ready for merge yet, but you're welcome to review the requested changes.

spadgett · 2016-11-23T16:14:06Z

app/scripts/controllers/createFromURL.js

+              });
+          }, function(e) {
+            if(e.status === 403) {
+              alertInaccessibleNamespace(createDetails.namespace, e);


You might have access to the namespace, but not the image stream. I'd change the message to say specifically that you don't have access to the image stream or template.

spadgett · 2016-11-23T16:16:55Z

app/scripts/controllers/createFromURL.js

+        type: "error",
+        message: namespace ?
+                  "Resources from the namespace \"" + namespace + "\" are not permitted." :
+                  "A valid namespace is required."


Let's open a follow-on issue to add a doc link here for whitelisting namespaces.

spadgett · 2016-11-23T16:18:35Z

app/scripts/controllers/createFromURL.js

+    var alertInvalidImageStream = function(imageStream, e) {
+      $scope.alerts.invalidImageStream = {
+        type: "error",
+        message: "The requested image stream \"" + imageStream + "\" is not valid.",


Suggest a more general message saying "Could not load image stream ..." instead of saying "not valid." It might be valid, but we couldn't load it for another reason. Same for templates.

spadgett · 2016-11-23T16:20:08Z

app/scripts/controllers/createFromURL.js

+      $scope.alerts.inaccessibleNamespace = {
+        type: "error",
+        message: "You do not have access to the namespace \"" + namespace + "\".",
+        details: "Reason: " + $filter('getErrorDetails')(e)


getErrorDetails can in some cases return an empty string, so you could have "Reason: " with nothing following. We should either fix the filter or leaving off "Reason:".

(I realize we have this problem in many places in existing code.)

spadgett · 2016-11-23T16:40:46Z

app/scripts/controllers/createFromURL.js

+    var whiteListedCreateDetailsKeys = ['namespace', 'app', 'imageStream', 'imageTag', 'sourceURI', 'sourceRef', 'contextDir', 'template', 'templateParamsMap'];
+    var createDetails = _.pick($routeParams, function(value, key) {
+      // routeParams without a value (e.g., ?app&) return true, which results in "true" displaying in the UI
+      return _.contains(whiteListedCreateDetailsKeys, key) && (value && value !== true);


Maybe

return _.contains(whiteListedCreateDetailsKeys, key) && _.isString(value);

That doesn't work. Presumably because the boolean gets converted to a string?

spadgett · 2016-11-23T16:46:13Z

app/scripts/controllers/createFromURL.js

+      catch (e) {
+        $scope.alerts.invalidTemplateParams = {
+          type: "error",
+          message: "The template parameters are not valid."


We should say specifically that it's not valid JSON and ideally show the syntax error details from e if present.

spadgett · 2016-11-23T16:48:06Z

app/scripts/controllers/newfromtemplate.js

+      catch (e) {
+        $scope.alertsTop.invalidTemplateParams = {
+          type: "error",
+          message: "The template parameters are not valid."


Same comment as above about JSON parsing.

spadgett · 2016-11-23T16:50:04Z

app/scripts/controllers/newfromtemplate.js

+            var templateParams = getValidTemplateParamsMap();
+            _.each($scope.template.parameters, function(parameter) {
+              if (templateParams[parameter.name]) {
+                parameter.value = templateParams[parameter.name];


Did we switch back to array for this controller? I think it would be better to use a map everywhere to be consistent if possible.

Not sure I (we) understand the question. $scope.template.parameters is the existing array that was already in use on the page.

Sorry, I misread the code. Disregard.

spadgett · 2016-11-23T16:53:30Z

app/views/newfromtemplate.html

@@ -16,6 +16,7 @@
                  {{ emptyMessage }}
                </div>
                <div class="osc-form" ng-show="template">
+                  <alerts alerts="alertsTop" hide-close-button="true"></alerts>


I understand why you added this, but not sure we should have multiple alerts directives on this page. @jwforres Opinion? Were the alerts moved down for the quota changes?

yeah they were moved for the quota change because you would submit the form and not see the errors if they were scrolled off the top of the page

This feels like a general problem with our alerts we might try and solve. Assuming it can happen with other forms, too.

We talked about moving to toasts at one point, which I think would work as they are fixed position & lay on top of the screen. Maybe we consider again?

rhamilto · 2016-11-28T18:37:48Z

Blocked by openshift/origin#12044

benjaminapetersen · 2016-11-30T21:46:05Z

So it still seems like we could do a better job with a visual cue implying that the user will be installing a significant piece of software. I mentioned a tile before, though I know there were qualms. A rough side by side:

I can roll with it if we generally think the plain text approach is sufficient, but wanted to bring it up one more time.

benjaminapetersen · 2016-12-01T03:11:38Z

test/integration/create-from-url/createFromURLTemplate.spec.js

+      page.visit(qs);
+      expect(element(by.css('h1')).getText()).toEqual('Node.js 4');
+    });
+    it('should create a project to add to', function(){


A quick thoughts here. an it() should have an expect() inside as an assertion of something, otherwise its not quite a test. After the tab.click() we can probably browser.wait() then check that the url contains the project name?

Yeah. The expects are going to be confirmation of the query string params in the corresponding fields. I just haven't gotten there yet. :)

benjaminapetersen · 2016-12-01T03:13:02Z

test/integration/create-from-url/createFromURLTemplate.spec.js

+      expect(element(by.css('h1')).getText()).toEqual('Node.js + MongoDB (Ephemeral)');
+    });
+    it('should use an existing project', function(){
+      // if the tabs are not on the page, create a new project instead


Same, we should expect() in here so that the test will pass or fail.

benjaminapetersen · 2016-12-01T03:16:46Z

test/integration/helpers.js

@@ -92,3 +96,31 @@ exports.waitFor = function(item, timeout, msg) {
  msg = msg || '';
  return browser.wait(item, timeout, msg);
 };
+


I like that we can reuse this. Maybe we should do a helpers/ directory & put this in helpers/projectHelpers.js

rhamilto · 2016-12-05T19:49:22Z

@spadgett, I think @benjaminapetersen have successfully added sufficient e2e tests, so I believe this is ready for final review.

rhamilto · 2016-12-05T19:51:19Z

So it still seems like we could do a better job with a visual cue implying that the user will be installing a significant piece of software. I mentioned a tile before, though I know there were qualms. A rough side by side:

For me, the tile disassociates the image stream or template description from the project selection. They no longer feel like they're part of the same thing.

spadgett · 2016-12-05T20:22:29Z

app/scripts/constants.js

-  ]
+  ],
+  // 'openshift' should always be included
+  CREATE_FROM_URL_WHITELIST: ['openshift']


I'd move this above PROJET_NAVIGATION because it's a bit easy to miss below the two long constants.

Suggest adding more comments describing what it is. I'd like the file to be as self-documenting as possible since we expect admins to customize these values.

spadgett · 2016-12-05T20:36:01Z

app/scripts/controllers/createFromURL.js

+    createDetails.namespace = createDetails.namespace || 'openshift';
+
+    var validateApp = function (app) {
+      return /^[a-z]([-a-z0-9]*[a-z0-9])?$/.test(app);


Should also check it's not longer than 63 characters.

Good catch. I will add a check for length. The max characters for app name is 24.

Thanks, yeah. Create from source limit is 24, you're right.

How do we handle app for templates? Do we set it as the app label? That limit would be 63.

Given template params are completely open-ended (defined in the template), we don't try to validate any of them (including app aka name).

I'm thinking we should change this to name so it's not confused with the app label. It's also consistent with oc new-app and the label we uses in the web console.

--name='': Set name to use for generated application artifacts

spadgett · 2016-12-05T20:41:07Z

app/scripts/services/projects.js

@@ -64,6 +65,9 @@ angular.module('openshiftConsole')
          update: function(projectName, data) {
            return DataService
                    .update('projects', projectName, cleanEditableAnnotations(data), {projectName: projectName}, {errorNotification: false});
+          },
+          canCreate: function() {
+              return DataService.get("projectrequests", null, {}, { errorNotification: false});


nit: indentation

Looks at @benjaminapetersen. ;-)

spadgett · 2016-12-05T20:42:56Z

app/views/create-from-url.html

+                        <ui-select-match placeholder="Project name">
+                          {{$select.selected | uniqueDisplayName : projects}}
+                        </ui-select-match>
+                        <ui-select-choices repeat="project in projects | filter : { metadata: { name: $select.search }}">


Need to filter on display name as well if that's what we're showing.

spadgett · 2016-12-05T20:43:37Z

app/views/create-from-url.html

+                            <ui-select-match placeholder="Project name">
+                              {{$select.selected | uniqueDisplayName : projects}}
+                            </ui-select-match>
+                            <ui-select-choices repeat="project in projects | filter : { metadata: { name: $select.search }}">


Same comment: Need to filter on display name as well.

rhamilto · 2016-12-05T22:31:38Z

@spadgett, comments addressed.

benjaminapetersen · 2016-12-05T22:36:24Z

Btw, tests are in line with the PageObjects PR I opened a good while ago, hoping to more easily iterate after this merges.

spadgett · 2016-12-06T14:07:34Z

@benjaminapetersen @rhamilto thank you for writing a lot of tests on this

benjaminapetersen · 2016-12-06T15:37:52Z

The "public api" of this PR is currently the following:

['namespace', 'app', 'imageStream', 'imageTag', 'sourceURI', 'sourceRef', 'contextDir', 'template', 'templateParamsMap'];

Just confirming we are good with that. The only one I was not 100% on was templateParamsMap, if it should be shortened to templateParams or something similar.

spadgett · 2016-12-06T15:45:04Z

We might change app to name for consistency with the CLI and field label, @jwforres ?

jwforres · 2016-12-06T16:16:44Z

name makes sense

…

On Tue, Dec 6, 2016 at 10:45 AM, Sam Padgett ***@***.***> wrote: We might change app to name for consistency with the CLI and field label, @jwforres <https://github.com/jwforres> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#884 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABZk7Rvizdob2q_CkmC_jZWwQwlEVedJks5rFYMBgaJpZM4K0eNa> .

rhamilto · 2016-12-06T17:33:57Z

I've renamed the query string param "app" to "name".

spadgett · 2016-12-06T18:25:06Z

[merge]

spadgett · 2016-12-06T19:23:01Z

@benjaminapetersen @rhamilto some test failures in jenkins

rhamilto · 2016-12-06T21:15:11Z

@spadgett and @benjaminapetersen, I removed the tests commit from the PR and moved it to a different branch so the feature commit can merge.

spadgett · 2016-12-06T21:25:05Z

[merge]

openshift-bot · 2016-12-06T21:31:15Z

Evaluated for origin web console merge up to 094a415

openshift-bot · 2016-12-06T21:31:26Z

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/818/) (Base Commit: d264ce4)

rhamilto changed the title ~~[WIP]: Adding "Run on OpenShift" functionality~~ Adding "Run on OpenShift" functionality Nov 18, 2016

spadgett requested changes Nov 18, 2016

View reviewed changes

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2016

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2016

spadgett requested changes Nov 23, 2016

View reviewed changes

rhamilto mentioned this pull request Nov 28, 2016

oAuth redirect then doesn't allow multiple query string parameters openshift/origin#12044

Closed

spadgett mentioned this pull request Nov 30, 2016

Improve guidance when there are no pipelines to show #953

Merged

spadgett self-assigned this Nov 30, 2016

benjaminapetersen reviewed Dec 1, 2016

View reviewed changes

spadgett reviewed Dec 5, 2016

View reviewed changes

spadgett approved these changes Dec 6, 2016

View reviewed changes

Adding "Run on OpenShift" functionality

094a415

spadgett approved these changes Dec 6, 2016

View reviewed changes

openshift-bot merged commit a9f4523 into openshift:master Dec 6, 2016

rhamilto deleted the run-on branch December 6, 2016 21:48

rhamilto mentioned this pull request Dec 9, 2016

Adding Create From URL documentation openshift/openshift-docs#3353

Merged

Adding "Run on OpenShift" functionality #884

Adding "Run on OpenShift" functionality #884

Conversation

rhamilto commented Nov 16, 2016 • edited Loading

spadgett commented Nov 17, 2016

rhamilto commented Nov 17, 2016 • edited Loading

benjaminapetersen commented Nov 17, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jwforres commented Nov 22, 2016

@rhamilto commented on this pull request.

rhamilto commented Nov 22, 2016 • edited Loading

rhamilto commented Nov 22, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhamilto commented Nov 28, 2016

benjaminapetersen commented Nov 30, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhamilto commented Dec 5, 2016

rhamilto commented Dec 5, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spadgett Dec 6, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhamilto commented Dec 5, 2016

benjaminapetersen commented Dec 5, 2016

spadgett commented Dec 6, 2016

benjaminapetersen commented Dec 6, 2016

spadgett commented Dec 6, 2016

jwforres commented Dec 6, 2016 via email

rhamilto commented Dec 6, 2016

spadgett commented Dec 6, 2016

spadgett commented Dec 6, 2016

rhamilto commented Dec 6, 2016

spadgett commented Dec 6, 2016

openshift-bot commented Dec 6, 2016

openshift-bot commented Dec 6, 2016 • edited Loading

rhamilto commented Nov 16, 2016 •

edited

Loading

rhamilto commented Nov 17, 2016 •

edited

Loading

benjaminapetersen commented Nov 17, 2016 •

edited

Loading

rhamilto commented Nov 22, 2016 •

edited

Loading

spadgett Dec 6, 2016 •

edited

Loading

openshift-bot commented Dec 6, 2016 •

edited

Loading