Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1333162 Improve descriptions for quota scopes #887

Merged
merged 1 commit into from
Nov 21, 2016

Conversation

jwforres
Copy link
Member

@jwforres
Copy link
Member Author

@spadgett PTAL

@spadgett
Copy link
Member

cc @derekwaynecarr

We originally used the same wording as the CLI. Do we want to update the CLI as well?

@jwforres
Copy link
Member Author

some of these are specific to openshift, like the one that references builds, so if did update the CLI we would probably need to have different text in kubectl vs oc, or just change the text in oc

@jwforres
Copy link
Member Author

cc @fabianofranz @juanvallejo for the CLI discussion

@juanvallejo
Copy link
Contributor

I think these two updates would be fine for both openshift and kubernetes

"BestEffort": "Affects pods that do not have resource limits set. These pods have a best effort quality of service.",
"NotBestEffort": "Affects pods that have at least one resource limit set. These pods do not have a best effort quality of service."

Not sure if the concept of "applications" exists upstream, if this is the case, maybe we could list more detail on what consists of an application?

"NotTerminating": "Affects pods that do not have an active deadline. These pods usually include your applications.",

@fabianofranz WDYT?

@jwforres
Copy link
Member Author

I don't think the strings necessarily need to match 100% between the CLI and the console, but @juanvallejo can you open an issue for the CLI in origin to consider changing the CLI strings.

@spadgett can we merge this?

@spadgett
Copy link
Member

[merge]

@juanvallejo
Copy link
Contributor

@jwforres

I don't think the strings necessarily need to match 100% between the CLI and the console, but @juanvallejo can you open an issue for the CLI in origin to consider changing the CLI strings.

Sounds good, opened issue here openshift/origin#11985

@jwforres
Copy link
Member Author

had to abort previous job, it was stuck [merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 3eb8f16

@openshift-bot
Copy link

openshift-bot commented Nov 21, 2016

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/744/) (Base Commit: 843d4ae)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants