-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1333162 Improve descriptions for quota scopes #887
Conversation
@spadgett PTAL |
We originally used the same wording as the CLI. Do we want to update the CLI as well? |
some of these are specific to openshift, like the one that references builds, so if did update the CLI we would probably need to have different text in kubectl vs oc, or just change the text in oc |
cc @fabianofranz @juanvallejo for the CLI discussion |
I think these two updates would be fine for both openshift and kubernetes
Not sure if the concept of "applications" exists upstream, if this is the case, maybe we could list more detail on what consists of an application?
@fabianofranz WDYT? |
I don't think the strings necessarily need to match 100% between the CLI and the console, but @juanvallejo can you open an issue for the CLI in origin to consider changing the CLI strings. @spadgett can we merge this? |
[merge] |
Sounds good, opened issue here openshift/origin#11985 |
had to abort previous job, it was stuck [merge] |
Evaluated for origin web console merge up to 3eb8f16 |
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/744/) (Base Commit: 843d4ae) |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1333162