Let users add config maps and secrets as volumes #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
force-pushed
the
add-config-map-secret-volume
branch
2 times, most recently
from
c961884 to
5f43d1e
Compare
jwforres
reviewed
Nov 22, 2016
| @@ -24,6 +24,15 @@ angular.module('openshiftConsole') | |||
| return input; | |||
| }; | |||
| }) | |||
| .filter('keys', function() { | |||
| return function(obj) { | |||
| if (!obj) { | |||
There was a problem hiding this comment.
what about return _.keys(obj);
spadgett
force-pushed
the
add-config-map-secret-volume
branch
from
5f43d1e to
8e7b54f
Compare
|
@jwforres updated with a second commit for removing volumes |
jwforres
reviewed
Nov 22, 2016
| } | ||
|
|
||
| var triggers = _.get($scope, 'deploymentConfig.spec.triggers', []); | ||
| return _.some(triggers, { type: 'ConfigChange' }); |
There was a problem hiding this comment.
should you be checking automatic true?
There was a problem hiding this comment.
not for config change, only image change
| $scope.removeVolume = function(volume) { | ||
| var details; | ||
| if (isConfigChangeActive()) { | ||
| details = "This will remove the volume from the deployment config and trigger a new deployment."; |
There was a problem hiding this comment.
should we be clear that it will not delete the PVC/Secret/ConfigMap?
spadgett
force-pushed
the
add-config-map-secret-volume
branch
from
8e7b54f to
40eedd8
Compare
|
@jwforres updated |
jwforres
approved these changes
Nov 22, 2016
|
[merge] |
|
Evaluated for origin web console merge up to 40eedd8 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/755/) (Base Commit: bc496f8) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/gUzfL5OA
@jwforres PTAL
Add all keys:
Add specific keys: