Create new config maps and secrets when adding config files #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
force-pushed
the
add-config-files-create
branch
from
4871bef to
8296cbe
Compare
|
Changed link casing to "Change secret" |
jwforres
reviewed
Nov 29, 2016
| @@ -22,18 +22,7 @@ | |||
| </div> | |||
|
|
|||
| <div ng-if="targetObject && configMaps && secrets"> | |||
| <div ng-if="!configMaps.length && !secrets.length" class="empty-state-message empty-state-full-page"> | |||
There was a problem hiding this comment.
Should we keep this for the case where you aren't authorized to create secrets / config maps?
Let users create a new config map or secret directly from the "add config files" page.
spadgett
force-pushed
the
add-config-files-create
branch
from
8296cbe to
a7e1273
Compare
|
@jwforres updated |
jwforres
approved these changes
Nov 29, 2016
|
[merge] |
|
Evaluated for origin web console merge up to a7e1273 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/774/) (Base Commit: cf4e107) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let users create a new config map or secret directly from the "add config files" page.
https://trello.com/c/gUzfL5OA
@jwforres PTAL