Show correct image stream name on deploy image #976
Conversation
| @@ -73,7 +73,8 @@ | |||
| administrator. | |||
| </div> | |||
| <h2> | |||
| {{app.name}}<span ng-if="import.tag">:{{import.tag}}</span> | |||
| <span ng-if="mode === 'dockerImage'">{{app.name}}<span ng-if="import.tag">:{{import.tag}}</span></span> | |||
There was a problem hiding this comment.
hmm does it make sense to be changing that header at all? isn't that header the name and metadata of the image?
There was a problem hiding this comment.
Yeah we can change it for the other case. The difference is that we will actually create an image stream tag with that value in your project for mode === 'dockerImage'
There was a problem hiding this comment.
Do we have a line that tells you we will create an image stream? That seems like the right thing vs changing the name of the image that we loaded.
If I deploy from an image stream image and customize the app name, don't change the image stream name in the summary header.
spadgett
force-pushed
the
fix-deploy-ist-title
branch
from
07261f2 to
55cf6b4
Compare
|
@jwforres another look? |
|
[merge] |
|
Evaluated for origin web console merge up to 55cf6b4 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/797/) (Base Commit: 9647628) |
If I deploy from an image stream image and customize the app name, don't
change the image stream name in the summary header.
Fixes #973
@jwforres PTAL