-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show build status message when it exists #989
Conversation
Note there are currently some issues with the messages showing up so i could only test cancelled openshift/origin#12146 |
Should we add it to the build config page as well for latest build? |
fcbaf7a
to
f8229ec
Compare
@spadgett updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one nit on the commented out code
</td> | ||
<td data-title="Status"> | ||
<div row class="status"> | ||
<build-status build="build"></build-status> | ||
<!-- <build-status build="build"></build-status> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented out code
f8229ec
to
eeb4ffa
Compare
fixed [merge] |
Evaluated for origin web console merge up to eeb4ffa |
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/814/) (Base Commit: a8bd114) |
Implements https://trello.com/c/Of6LXNUi