Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show build status message when it exists #989

Merged
merged 1 commit into from
Dec 6, 2016

Conversation

jwforres
Copy link
Member

@jwforres jwforres commented Dec 5, 2016

@jwforres
Copy link
Member Author

jwforres commented Dec 5, 2016

status-message

@jwforres
Copy link
Member Author

jwforres commented Dec 5, 2016

@spadgett

Note there are currently some issues with the messages showing up so i could only test cancelled openshift/origin#12146

@spadgett
Copy link
Member

spadgett commented Dec 5, 2016

@spadgett spadgett self-assigned this Dec 5, 2016
@jwforres jwforres force-pushed the build-failure-reason branch from fcbaf7a to f8229ec Compare December 6, 2016 17:20
@jwforres
Copy link
Member Author

jwforres commented Dec 6, 2016

@spadgett updated

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit on the commented out code

</td>
<td data-title="Status">
<div row class="status">
<build-status build="build"></build-status>
<!-- <build-status build="build"></build-status> -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out code

@jwforres jwforres force-pushed the build-failure-reason branch from f8229ec to eeb4ffa Compare December 6, 2016 17:41
@jwforres
Copy link
Member Author

jwforres commented Dec 6, 2016

fixed [merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to eeb4ffa

@openshift-bot
Copy link

openshift-bot commented Dec 6, 2016

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/814/) (Base Commit: a8bd114)

@openshift-bot openshift-bot merged commit e024781 into openshift:master Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants