SecurityContextConstraints: avoid unnecessary mutation of supplementa…

…l groups.
openshift · Dec 18, 2017 · 1b41ef7 · 1b41ef7
1 parent 2e79df0
commit 1b41ef7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/security/securitycontextconstraints/group/runasany.go b/pkg/security/securitycontextconstraints/group/runasany.go
@@ -18,7 +18,7 @@ func NewRunAsAny() (GroupSecurityContextConstraintsStrategy, error) {
 
 // Generate creates the group based on policy rules.  This strategy returns an empty slice.
 func (s *runAsAny) Generate(pod *api.Pod) ([]int64, error) {
-	return []int64{}, nil
+	return nil, nil
 }
 
 // Generate a single value to be applied.  This is used for FSGroup.  This strategy returns nil.

diff --git a/pkg/security/securitycontextconstraints/provider.go b/pkg/security/securitycontextconstraints/provider.go
@@ -124,7 +124,7 @@ func (s *simpleProvider) CreatePodSecurityContext(pod *api.Pod) (*api.PodSecurit
 		}
 	}
 
-	if len(sc.SupplementalGroups) == 0 {
+	if sc.SupplementalGroups == nil {
 		supGroups, err := s.supplementalGroupStrategy.Generate(pod)
 		if err != nil {
 			return nil, nil, err