Skip to content

Commit

Permalink
Merge pull request #18761 from mfojtik/fix-dc-cancel-flake
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue (batch tested with PRs 18754, 18761).

apps: stop dc cancellation flake

This stops the flake as the conflict message has changed (?). It does not fix the root cause, which should be investigated and fixed (/cc @tnozicka)

Fixes: #18743
  • Loading branch information
openshift-merge-robot authored Feb 27, 2018
2 parents e2e14cb + 1ba8441 commit 1f02cb5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion test/extended/deployments/deployments.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,9 @@ var _ = g.Describe("[Feature:DeploymentConfig] deploymentconfigs", func() {
e2e.Logf("%02d: cancelling deployment", i)
if out, err := oc.Run("rollout").Args("cancel", "dc/deployment-simple").Output(); err != nil {
// TODO: we should fix this
if !strings.Contains(out, "the object has been modified") && !strings.Contains(out, "there have been no replication controllers") {
if !strings.Contains(out, "the object has been modified") &&
!strings.Contains(out, "there have been no replication controllers") &&
!strings.Contains(out, "there is a meaningful conflict") {
o.Expect(err).NotTo(o.HaveOccurred())
}
e2e.Logf("rollout cancel deployment failed due to known safe error: %v", err)
Expand Down

0 comments on commit 1f02cb5

Please sign in to comment.