Adding generic build failed reason

Adding a generic build failed reason to display to display
for build failures that do not have a more specific reason

pkg/build/api/types.go

@@ -331,6 +331,10 @@ const (
 	// StatusReasonBuildPodExists indicates that the build tried to create a
 	// build pod but one was already present.
 	StatusReasonBuildPodExists StatusReason = "BuildPodExists"
+
+	// StatusReasonGenericBuildFailed is the reason associated with a broad
+	// range of build failures.
+	StatusReasonGenericBuildFailed StatusReason = "GenericBuildFailed"
 )
 
 // NOTE: These messages might change.
@@ -350,6 +354,7 @@ const (
 	StatusMessageCancelledBuild            = "The build was cancelled by the user."
 	StatusMessageDockerBuildFailed         = "Docker build strategy has failed."
 	StatusMessageBuildPodExists            = "The pod for this build already exists and is older than the build."
+	StatusMessageGenericBuildFailed        = "Generic Build failure - check logs for details."
 )
 
 // BuildStatusOutput contains the status of the built image.

pkg/build/controller/controller.go

@@ -343,6 +343,10 @@ func (bc *BuildPodController) HandlePod(pod *kapi.Pod) error {
 
 		case kapi.PodFailed:
 			nextStatus = buildapi.BuildPhaseFailed
+			if build.Status.Reason == "" {
+				build.Status.Reason = buildapi.StatusReasonGenericBuildFailed
+				build.Status.Message = buildapi.StatusMessageGenericBuildFailed
+			}
 
 		default:
 			build.Status.Reason = ""

test/extended/builds/failure_status.go

@@ -28,6 +28,7 @@ var _ = g.Describe("[builds][Slow] update failure status", func() {
 		pushToRegistryFixture        = exutil.FixturePath("testdata", "statusfail-pushtoregistry.yaml")
 		fetchRuntimeArtifactsFixture = exutil.FixturePath("testdata", "statusfail-runtimeartifacts.yaml")
 		failedAssembleFixture        = exutil.FixturePath("testdata", "statusfail-failedassemble.yaml")
+		failedGenericReason          = exutil.FixturePath("testdata", "statusfail-genericreason.yaml")
 		binaryBuildDir               = exutil.FixturePath("testdata", "statusfail-assemble")
 		oc                           = exutil.NewCLI("update-buildstatus", exutil.KubeConfigPath())
 	)
@@ -156,4 +157,21 @@ var _ = g.Describe("[builds][Slow] update failure status", func() {
 			o.Expect(build.Status.Message).To(o.Equal(messageFetchRuntimeArtifacts))
 		})
 	})
+
+	g.Describe("Build status failed https proxy invalid url", func() {
+		g.It("should contain the generic failure reason and message", func() {
+			err := oc.Run("create").Args("-f", failedGenericReason).Execute()
+			o.Expect(err).NotTo(o.HaveOccurred())
+
+			br, err := exutil.StartBuildAndWait(oc, "statusfail-genericfailure", "--build-loglevel=5")
+			o.Expect(err).NotTo(o.HaveOccurred())
+			br.AssertFailure()
+			br.DumpLogs()
+
+			build, err := oc.Client().Builds(oc.Namespace()).Get(br.Build.Name)
+			o.Expect(err).NotTo(o.HaveOccurred())
+			o.Expect(build.Status.Reason).To(o.Equal(buildapi.StatusReasonGenericBuildFailed))
+			o.Expect(build.Status.Message).To(o.Equal(buildapi.StatusMessageGenericBuildFailed))
+		})
+	})
 })

test/extended/testdata/statusfail-genericreason.yaml

@@ -0,0 +1,18 @@
+kind: BuildConfig
+apiVersion: v1
+metadata:
+  name: statusfail-genericfailure
+spec:
+  source:
+    git:
+      uri: "https://github.com/openshift/ruby-ex"
+  strategy:
+    type: Source
+    sourceStrategy:
+      from:
+        kind: DockerImage
+        name: centos/ruby-23-centos7:latest
+      scripts: "http://example.org/scripts"
+      env:
+        - name: http_proxy
+          value: ":http://example.org"