Skip to content

Commit

Permalink
UPSTREAM: 54701: Refactor reconcileAutoscaler method in hpa
Browse files Browse the repository at this point in the history
There have been a couple of recent bugs in the "normalizing" part of the
`reconcileAutoscaler` method. This part of the code base is responsible
for, among other things, taking the suggested desired replicas based on
the metrics, ensuring it conforms to certain conditions, and updating it
if it does not. Isolate the part that converts the desired replicas
based on a given set of rules into its own function.

We are refactoring this part of the code base to make the logic simpler
and to make it easier to write unit tests.
  • Loading branch information
mattjmcnaughton authored and RobertKrawitz committed Jan 22, 2018
1 parent 5a1cc4c commit 2e90d35
Show file tree
Hide file tree
Showing 2 changed files with 137 additions and 44 deletions.
110 changes: 70 additions & 40 deletions vendor/k8s.io/kubernetes/pkg/controller/podautoscaler/horizontal.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2e90d35

Please sign in to comment.