Run reflector in a goroutine

openshift · Nov 6, 2017 · 50e1bd3 · 50e1bd3
1 parent 21e04c5
commit 50e1bd3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/pkg/apps/strategy/support/lifecycle.go b/pkg/apps/strategy/support/lifecycle.go
@@ -467,7 +467,7 @@ func newPodWatch(client kcoreclient.PodInterface, namespace, name, resourceVersi
 	}
 
 	queue := cache.NewResyncableFIFO(cache.MetaNamespaceKeyFunc)
-	cache.NewReflector(podLW, &kapi.Pod{}, queue, 1*time.Minute).Run(stopChannel)
+	go cache.NewReflector(podLW, &kapi.Pod{}, queue, 1*time.Minute).Run(stopChannel)
 
 	return func() *kapi.Pod {
 		obj := cache.Pop(queue)

diff --git a/pkg/network/common/common.go b/pkg/network/common/common.go
@@ -188,7 +188,7 @@ func newEventQueue(client kcache.Getter, resourceName ResourceName, expectedType
 	eventQueue := NewEventQueue(DeletionHandlingMetaNamespaceKeyFunc)
 	// Repopulate event queue every 30 mins
 	// Existing items in the event queue will have watch.Modified event type
-	kcache.NewReflector(lw, expectedType, eventQueue, 30*time.Minute).Run(wait.NeverStop)
+	go kcache.NewReflector(lw, expectedType, eventQueue, 30*time.Minute).Run(wait.NeverStop)
 	return eventQueue
 }
 

diff --git a/pkg/router/template/service_lookup.go b/pkg/router/template/service_lookup.go
@@ -29,7 +29,7 @@ func NewListWatchServiceLookup(svcGetter kcoreclient.ServicesGetter, resync time
 			return svcGetter.Services(api.NamespaceAll).Watch(options)
 		},
 	}
-	cache.NewReflector(lw, &api.Service{}, svcStore, resync).Run(wait.NeverStop)
+	go cache.NewReflector(lw, &api.Service{}, svcStore, resync).Run(wait.NeverStop)
 
 	return &serviceLWLookup{
 		store: svcStore,