UPSTREAM: 16590: Create all streams before copying in exec/attach

Create error, stdin, stdout, stderr streams first, and only start copying once all the streams have been created. This fixes an issue where the client immediately starts sending data for stdin before all the other streams have been created. This ends up blocking the spdy connection frame handler and causes the entire exec/attach session to time out.
openshift · Nov 2, 2015 · 50f9a4f · 50f9a4f
1 parent 0e08c78
commit 50f9a4f
Show file tree

Hide file tree

Showing 2 changed files with 76 additions and 42 deletions.
diff --git a/Godeps/_workspace/src/k8s.io/kubernetes/pkg/client/unversioned/remotecommand/v1.go b/Godeps/_workspace/src/k8s.io/kubernetes/pkg/client/unversioned/remotecommand/v1.go
diff --git a/Godeps/_workspace/src/k8s.io/kubernetes/pkg/client/unversioned/remotecommand/v2.go b/Godeps/_workspace/src/k8s.io/kubernetes/pkg/client/unversioned/remotecommand/v2.go